fix(ratelimiter): resolve data race in token bucket#17
Open
its-jojoo wants to merge 1 commit into
Open
Conversation
its-jojoo
force-pushed
the
fix/rate-limiter-race-condition
branch
2 times, most recently
from
February 7, 2026 23:09
fc5457a to
a1925c4
Compare
Author
its-jojoo
force-pushed
the
fix/rate-limiter-race-condition
branch
from
February 8, 2026 01:14
a1925c4 to
3c8e92d
Compare
its-jojoo
force-pushed
the
fix/rate-limiter-race-condition
branch
from
February 8, 2026 19:25
3c8e92d to
d043200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Fixes a data race in the token bucket rate limiter where multiple goroutines could concurrently write to
entry.LastSeenwithout synchronization.Problem
The Go race detector flagged concurrent writes in
getEntry():Solution
LastSeenfromtime.Timetoint64(Unix nanoseconds) for atomic operationsatomic.StoreInt64for writes andatomic.LoadInt64for readsgetEntry()withRLockfor better read performanceTesting
go test -race- no data races detectedPerformance Impact
Neutral to positive - uses
RLockfor reads instead of fullLock