Split ranger binary into lib and binary.#40
Open
0x7f wants to merge 362 commits into
Open
Conversation
added 30 commits
February 5, 2015 10:40
Tree split weights (issue imbs-hl#15)
add option to keep inbag counts of observations per tree, issue imbs-hl#28
add sample.fraction option to control fraction of samples sampled, is…
Fix prediction problem
Fix bug if survival tree without OOB observations
To allow embedding the ranger functionality into other applications, move the functionality into a separate library and just put the main.cpp in the ranger binary target.
Member
|
We still want this, but this PR is quite outdated. :) |
Contributor
|
done in #686 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A draft for moving the ranger functionality into its own library.
When just calling
cmake .., it will build a static library and when settingBUILD_SHARED_LIBflag, i.e.cmake -DBUILD_SHARED_LIB=1 .., it will create a shared lib.Did not test on Windows yet where setting
__declspec(dllexport)is missing most probably.