Conversation
Restore the Further Details, Contributors and References blocks that were dropped in the original port, with a DOI for Kagstrom & Westin (1989).
Owner
Author
|
17 m 35s -> 13m 5s (Adagio 👏) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the downsides of running with LLM is that it slowly drifts and anything that is not test covered is missed. Hence the resulting PRs. It's not nothing, the gist of the docs is there. But the quality level is tripping.
Certain fields were missed and inline code markings were not working; backticks were not recognized. Now, a crude pass will be done with best effort backticking and obvious bugs will be fixed. And LAPACK docs are also choke full of bugs and inconsistencies (not complaining, I'm grateful nevertheless for the attention and care). There are always certain things are missed but the number of functions are simply just too high. So it will be a marathon and not a race.
Regarding doxygen,
@verbatimblocks don't remove the comment characters and then dedent properly (that's why it looks the way it looks on official LAPACK docs on Netlib). And it does not understand the markdown triple backtick machinery with@code{...}. So I used a@rstescape and then...code-block.Hopefully, this PR will settle the documentation machinery such that further changes will be docstring only. Once this is done, I can make a proper release.
Additional changes included
lasq2/lasq3XXXX_2stagefunctions). They are all regularized.