Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When linked to BLIS or LAPACK-less binaries, many mistakes are surfaced previously shadowed by stealing symbols from OpenBLAS or MKL. Stripping of LAPACK completely reveals that some obscure symbols were missing and fortran shim was causing a segfault in SciPy around ~56% of the test suite.
In the meantime a function was named wrongly, while internally consistent, the official name was
cdrscl. Fixed back to the correctcsrscl.cc: @agriyakhetarpal I think this was the reason why you were getting stuck in your work. Apologies for not getting this properly earlier. Apparently I only tested NumPy/SciPy with OpenBLAS/MKL but missed BLIS. It might very well be that your earlier attempts were stained by my mistake.
I'll merge after CI passes then make a dummy tag again.