Fix RegExp passed to String.startsWith() in checkChatMsg - #817
Draft
ikechan8370 with Copilot wants to merge 4 commits into
Draft
Fix RegExp passed to String.startsWith() in checkChatMsg#817ikechan8370 with Copilot wants to merge 4 commits into
ikechan8370 with Copilot wants to merge 4 commits into
Conversation
Co-authored-by: ikechan8370 <21212372+ikechan8370@users.noreply.github.com>
Co-authored-by: ikechan8370 <21212372+ikechan8370@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix startsWith function regex type issue in message.js
Fix RegExp passed to String.startsWith() in checkChatMsg
Nov 17, 2025
Owner
|
why did you commit the changes of package-lock.json? |
Owner
@copilot |
Co-authored-by: ikechan8370 <21212372+ikechan8370@users.noreply.github.com>
Contributor
Author
ikechan8370
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix type bug: startsWith function incorrectly passed RegExp type
Issue: Line 173 in
utils/message.jsincorrectly passes a RegExp object to thestartsWith()method, which expects a string parameter and throws an error when given a RegExp.Plan:
Changes Made:
e.msg.startsWith(prefixReg)toprefixReg.test(e.msg)on line 173package-lock.jsonfile (build artifact that shouldn't be committed)package-lock.jsonto.gitignoreto prevent future commitsVerification:
Security Summary:
No security vulnerabilities were introduced or found. CodeQL analysis returned 0 alerts.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.