fix: make landing page responsive on mobile - #74
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 624ad14de4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export default function LandingPage() { | ||
| return ( | ||
| <div className="min-h-screen bg-[#050e18] text-slate-200 relative"> | ||
| <div className="min-h-screen overflow-x-hidden bg-[#050e18] text-slate-200 relative"> |
There was a problem hiding this comment.
Preserve sticky navigation while clipping horizontal overflow
When the landing page is vertically scrolled, overflow-x-hidden makes this wrapper an overflow container (the other axis computes away from visible), so the sticky <nav> uses this expanding, non-scrolling ancestor instead of the viewport and scrolls out of view. Use overflow-x-clip or move the clipping to an element that does not contain the sticky navigation.
Useful? React with 👍 / 👎.
Fixes #3
Summary
Validation
npm.cmd run buildnpm.cmd exec vitest run src/pages/LandingPage.test.tsxNotes
npm.cmd testcurrently has one unrelated existing failure insrc/lib/api.test.tsaroundcredentials: include.npm.cmd run linthas unrelated existing lint errors outside the landing page.