Make sure that blind_corr_type is the one expected in the blinding template file#1148
Open
andreufont wants to merge 2 commits into
Open
Make sure that blind_corr_type is the one expected in the blinding template file#1148andreufont wants to merge 2 commits into
andreufont wants to merge 2 commits into
Conversation
Contributor
Author
|
@andreicuceu - this is a tiny PR to fix the issue I mentioned yesterday at the call. I don't think it is worth doing anything fancier at this point, and I checked that this works. |
Contributor
|
Hi @andreufont, sorry but I am doing a formating of all scripts in this PR: #1145 can you wait for this PR to be pushed and then make your modifications inside that ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow in DR3 the blinding file expects
lyaxqsoandlybxqso, but picca_export.py insisted on usingqsoxlyaandqsoxlyb.I didn't want to modify the template file, and I didn't want to break other people's scripts using picca_export, so I ended up renaming the variable internally in the code before reading the blinding template file.