Skip to content

Make LICENSE more apparent#477

Open
lambdakilo wants to merge 2 commits into
ietf-wg-jsonpath:mainfrom
lambdakilo:patch-1
Open

Make LICENSE more apparent#477
lambdakilo wants to merge 2 commits into
ietf-wg-jsonpath:mainfrom
lambdakilo:patch-1

Conversation

@lambdakilo

Copy link
Copy Markdown

Remove LICENSE.md as well due to it only referring to CONTRIBUTION. Do comment here if the license used here is wrong. I merely inferred it from the previous license text.

@gregsdennis gregsdennis left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure the existing license is intentional.

@lambdakilo

Copy link
Copy Markdown
Author

You think so? 'All rights reserved'? Could it be possible to modify it so that GitHub repository page can also show it as something it recognizes?

@gregsdennis

Copy link
Copy Markdown
Collaborator

Yes. This is an IETF project, and they likely want their license.

@cabo @timbray would you care to comment?

@cabo

cabo commented Jun 9, 2023

Copy link
Copy Markdown
Member

Ideally, the shape of the repository would be as described in RFC 8875; see https://www.rfc-editor.org/rfc/rfc8875.html#section-3.1 for one of the places this is discussed there.
This RFC was published in August 2020.
Glyn created the LICENSE file in July 2020.
So maybe we need to check whether everything is as discussed in RFC 8874/75.

@cabo

cabo commented Jun 9, 2023

Copy link
Copy Markdown
Member

'All rights reserved'?

This is a standard phrase in a copyright statement that is needed to make the copyright statement valid in certain jurisdictions.

Copyright is generally hard, because it needs to work in all jurisdictions, so I'd rather stick with what is normal here.
I'd point to an example repo by one of the people in the know, except I can't find one right now...

glyn added a commit that referenced this pull request Jun 9, 2023
Comment thread LICENSE
extracted from this document must include Simplified BSD License text
as described in Section 4.e of the Trust Legal Provisions and are
provided without warranty as described in the Simplified BSD License.
BSD 2-Clause License

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BSD license is only applicable to code components and not to specs. See https://trustee.ietf.org/
license-info.

@lambdakilo lambdakilo Jun 9, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping someone would notice this. Does it become too complicated if we restructure the code components to their own sub-directory and specs to their own so that we could get two LICENSE files pointing which materials have their corresponding licenses: https://softwareengineering.stackexchange.com/questions/304874/declaring-multiple-licences-in-a-github-project#answer-304895 ?

@cabo cabo Jun 9, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it become too complicated

I would probably answer this affirmatively.

Right now, we don't identify anything in the draft explicitly as a "code component".

The directory scripts could of course have its own license file -- none of this goes into the document, so it is useful to be explicit about the license (ignoring whether the "threshold of originality" is even reached).

The other potential code component is the ABNF, for which the scripts directory provides ways to extract it from the document, but the repo doesn't actually store the (computed) result. So there is no directory a license could be attached to.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good reasoning. However isn't the license currently too vague and interpretable?

@timbray

timbray commented Jun 9, 2023 via email

Copy link
Copy Markdown
Contributor

@cabo

cabo commented Jun 9, 2023 via email

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants