Use correct reader variable#58
Open
gabrielgio wants to merge 1 commit into
Open
Conversation
Gzip reader was not setting a variable but rather creating a new one. That led the "git-upload-pack" to received the compressed date rendering it unable to read the packet lines.
biox
approved these changes
Aug 3, 2025
maxwelljens
added a commit
to maxwelljens/legit
that referenced
this pull request
May 14, 2026
### Added - Reference links displayed in commit log page (icyphox#54) - Symlink resolution when scanning for git repositories (icyphox#59) ### Fixed - Malformed HTML in templates (icyphox#61) - Correct reader variable used in git operations (icyphox#58) ### Changed - Default scan path updated to /var/git (icyphox#60) - Dependency bumps: go-git v5.13.2, golang.org/x/crypto v0.31.0 - Path joining hardened with securejoin across all routes - Code quality: all golangci-lint issues resolved
pocka
added a commit
to pocka/legit
that referenced
this pull request
Jul 14, 2026
https://tangled.org/pocka.jp/legit/issues/6 icyphox#58 I could not write a test reliably triggers this condition (upload-pack request having gzip body) even with system git.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gzip reader was not setting a variable but rather creating a new one. That led the "git-upload-pack" to received the compressed date rendering it unable to read the packet lines.
That was a rather annoying bug to figure 😓