removed unused lib, updated docstring for throw exceptions#164
Open
Frederik-Hartmann wants to merge 4 commits into
Open
removed unused lib, updated docstring for throw exceptions#164Frederik-Hartmann wants to merge 4 commits into
Frederik-Hartmann wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I created this PR via VS Code with the wrong title — sorry about that. The correct title should be:
Add option to throw exceptions in convert_dir
This PR relates to: #113 (comment)
Changes
Added an argument
throw_exceptionsto raise exceptions (the first exception encountered will be raised). Default isFalsefor backwards compatibility.Replaced
traceback.print_exc()withlogger.warning(exc, exc_info=True)to maintain error information while logging, as suggested indicom2nifti/dicom2nifti/convert_dir.py
Line 56 in d68253e
throw_exceptions=True.It would be great if you could merge this PR @abrys to allow the use of dicom2nifti in our project. Thanks a lot in advance and thanks for maintaining this open source lib! It is much appreciated!