06 16 2026 resolve issue 87#617
Open
Treece-Burgess wants to merge 2 commits into
Open
Conversation
Treece-Burgess
added
component-host_micpower
Contributor
|
I'm reviewing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR closes #87 by updating the following Makefiles to use
CC ?=instead ofCC=:Testing
For
examples/Makefileandcomponents/powercap/utils/Makefile, testing took place on Picard at Oregon (Intel Xeon Gold 6430). In both cases, respective source code was successfully compiled and ran when exporting CC to an LLVM compiler (14.0.6) on the command line.For
components/rapl/utils/Makefile, testing took place on Hexane at ICL (Intel Xeon Silver 4309Y). In this single case, the respective source code was successfully compiled and ran when exporting CC to an LLVM compiler (14.0.6) on the command line.components/host_micpower/utils/Makefilewas unable to be tested.Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests