PAPI debug: Explicitly include unistd.h for getpid#612
Merged
dbarry9 merged 1 commit intoJun 18, 2026
Merged
Conversation
Contributor
|
I'm reviewing this PR. |
bfa4a53 to
cc5d43d
Compare
Contributor
|
I tested these changes on a system containing the AMD EPYC 7763 CPU (Zen3 architecture) using GCC 8.5.0 and 14.0.1. This feature branch compiled successfully and the PAPI utilities function properly. |
dbarry9
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
During development of the
cuda_rangecomponent, I encountered the below compilation error on Godzilla at Oregon (CPU: Intel Xeon CPU E5-2680, GPU: NVIDIA RTX PRO 6000 Blackwell, GCC 8.5.0):To resolve this error,
unistd.hmust be included inpapi_debug.has the declaration ofgetpidlives there.I did not encounter this behavior on Methane at ICL; however, this is most likely due to an implicit include for
unistd.hoccurring. It is considered best practice to be explicit about includes that are needed.Testing
After adding
#include <unistd.h>topapi_debug.hthecuda_rangecomponent compiled fine.Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests