topdown: Add component name (topdown:::) to topdown native events found in topdown_L1.c and topdown_L2.c#606
Open
Treece-Burgess wants to merge 1 commit into
Conversation
Treece-Burgess
added
type-maintenance
Contributor
|
I'm reviewing this PR. |
…nd in topdown_L1.c and topdown_L2.c
dbarry9
force-pushed
the
05-20-2026-topdown-tests-cmp-name
branch
from
07c8618 to
48f9659
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Currently in the master branch the
topdowncomponent teststopdown_L1.candtopdown_L2.cwill not successfully run as the hardcoded native events lack the component nametopdown:::.This PR resolves this behavior by adding the component name
topdown:::to each hardcoded native event.Testing
Testing was done on Headroom at Oregon (Intel(R) Xeon(R) Silver 4410T).
topdown_L1.c: ✅topdown_L2.c: ✅* -
papi_component_avail,papi_command_line,papi_native_availAuthor Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests