framework: For cuda native events - extend the string length in PAPI_event_code_to_name to be PAPI_2MAX_STR_LEN#596
Open
Treece-Burgess wants to merge 1 commit into
Conversation
…event_code_to_name to be PAPI_2MAX_STR_LEN
fa560b0 to
582fd04
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The Perfworks Metrics API can have metrics that are greater than
PAPI_MAX_STR_LEN. For example:This leads to
PAPI_event_code_to_namereturningPAPI_ENOMEM. This behavior can be seen on Hopper1 at Oregon (1 * GH200) with the testtest_multipass_event_fail.cu.This PR resolves this behavior by using
PAPI_2MAX_STR_LENif the eventcode provided by the user is found to be associated with thecudacomponent.Testing
Testing was done on Hopper1 at Oregon (CPU: ARM Neoverse-V2 , GPU: 1 * GH200) with Cuda Toolkit 12.8.1.
netcomponent tests: ✅coretempcomponent tests: ✅cudacomponent tests: ✅* -
papi_command_line,papi_component_avail,papi_native_availI have also verified that the ctests and ftests that call
PAPI_event_code_to_namedo not usecudacomponent native events, rather they use theperf_eventcomponent native events.Note: This is a temporary fix for this issue and a longer term fix will be applied at a later date.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests