nvml: Update the search logic to honor PAPI_NVML_MAIN, README.md, and Rules.nvml#595
Open
Treece-Burgess wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR updates the
nvmlcomponent to honorPAPI_NVML_MAINas an environment variable rather than a user needing to set the variable inRules.nvml. This makes thenvmlcomponent more in line with other components.Along with this, two other changes occur:
README.mdwas updated to reflect this aforementioned change.Rules.nvmlhasPAPI_CUDA_MAIN,PAPI_CUDA_RUNTIME, andPAPI_NVML_MAINremoved along with text that should have been placed in theREADME.md. Note that,PAPI_CUDA_MAINandPAPI_CUDA_RUNTIMEdo not have an equivalent environment variable added as didPAPI_NVML_MAIN. As these two environment variables are not used throughout thenvmlcomponent codebase.Testing
Testing was done on Methane at ICL (1 * A100) with Cuda Toolkit 12.9.
HelloWorld.cu: ✅* -
papi_component_avail,papi_native_avail, andpapi_command_lineAuthor Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests