framework: Properly handle the case of no components configured#589
Open
Treece-Burgess wants to merge 1 commit into
Open
framework: Properly handle the case of no components configured#589Treece-Burgess wants to merge 1 commit into
Treece-Burgess wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
In the master branch, if you configure PAPI as follows:
No components will be configured and this is indeed correct behavior. However, configure does not output anything for "checking for components to build..." and
papi_component_availshowsNative: 0, Preset: 0, Counters: 0, i.e.This PR updates this behavior as follows:
Testing
These changes were verified on Methane at ICL (CPU: Intel Xeon Gold 6140, OS: Rocky Linux 9.6 )
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests