fix: enhance RelayChain and SwapQuoteInfo models with new httpRpcUrl#3725
Open
ice-erebus wants to merge 1 commit into
Open
fix: enhance RelayChain and SwapQuoteInfo models with new httpRpcUrl#3725ice-erebus wants to merge 1 commit into
ice-erebus wants to merge 1 commit into
Conversation
ice-morpheus
force-pushed
the
bugfix/tx-confirmation-after-approve-on-dex-and-bridge
branch
from
240a3ca to
d00bb31
Compare
ice-tychon
reviewed
Mar 19, 2026
ice-tychon
approved these changes
Mar 19, 2026
ice-morpheus
force-pushed
the
bugfix/tx-confirmation-after-approve-on-dex-and-bridge
branch
4 times, most recently
from
4ce2648 to
6ac09fe
Compare
ice-priapus
reviewed
Mar 19, 2026
| return; | ||
| } | ||
|
|
||
| throw IonSwapException( |
Contributor
There was a problem hiding this comment.
is it worth make it more general, not only for swap? If so we could move it from swap client package and use IonIdentityTransactionException instead of IonSwapException
| throw IonSwapException('Failed to approve token allowance, tx hash: $txHash'); | ||
| final rcpUrl = swapQuoteInfo.sellBlockchainRcpUrl; | ||
| if (rcpUrl == null) { | ||
| await Future<void>.delayed(SwapConstants.delayAfterApproveDuration); |
Contributor
There was a problem hiding this comment.
so if rcpURL is null we are not having allowance check. is it ok?
| int maxTries = 20, | ||
| Duration pollInterval = const Duration(seconds: 3), | ||
| }) async { | ||
| if (!txHash.startsWith('0x') || txHash.length != 66) { |
Contributor
There was a problem hiding this comment.
don't we want to raise an exception in this case?
| mixin WaitForConfirmationMixin { | ||
| Future<void> waitForConfirmation({ | ||
| required String txHash, | ||
| required String rpcUrl, |
Contributor
There was a problem hiding this comment.
is some places i can see rpc and others rcp. is this a typo or two different things?
ice-morpheus
force-pushed
the
bugfix/tx-confirmation-after-approve-on-dex-and-bridge
branch
from
6ac09fe to
bf336b9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional Notes
Task ID
Type of Change
Screenshots (if applicable)