Skip to content

fix: push app open back navigation#3698

Open
ice-hades wants to merge 1 commit into
masterfrom
fix/push-nav-back
Open

fix: push app open back navigation#3698
ice-hades wants to merge 1 commit into
masterfrom
fix/push-nav-back

Conversation

@ice-hades

Copy link
Copy Markdown
Contributor

Description

  • Wait for splash to complete before handling a push

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation
  • Chore

@ice-hades ice-hades requested a review from ice-orion as a code owner March 17, 2026 15:45
@ice-morpheus ice-morpheus enabled auto-merge (squash) March 17, 2026 15:46
final initState = ref.read(initAppProvider);
final splashAnimationCompleted = ref.read(splashProvider);

if (initState.isLoading || !splashAnimationCompleted) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it already handled in lib/app/router/providers/go_router_provider.r.dart?
handleNotificationResponse is called only when isInitInProgress is false and isSplashAnimationCompleted is true there.

@ice-morpheus ice-morpheus force-pushed the fix/push-nav-back branch 17 times, most recently from c30460c to bbcd2cb Compare March 19, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants