fix: pass right type param, add session ttl handling#3653
Open
ice-evander wants to merge 1 commit into
Open
Conversation
ice-evander
requested review from
a team,
ice-hades and
ice-orion
as code owners
ice-evander
force-pushed
the
bugfix/tc-filter-creator-tokens-by-type
branch
from
c928aa0 to
c7dba46
Compare
ice-morpheus
force-pushed
the
bugfix/tc-filter-creator-tokens-by-type
branch
from
c7dba46 to
26f1597
Compare
ice-kreios
approved these changes
Mar 13, 2026
ice-morpheus
force-pushed
the
bugfix/tc-filter-creator-tokens-by-type
branch
11 times, most recently
from
71f778b to
e735c08
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates creator/community token type filtering to align with the analytics API’s expected type query parameter values, and improves reliability of category token viewing sessions by proactively refreshing before expiry.
Changes:
- Avoid sending empty
typevalues in latest tokens REST + SSE requests. - Update
TokenTypeFilter.requestTypemapping to new backend values (onlineplus_creator,onlineplus_content,xcom) and document backend-driven filtering. - Add a timer-driven viewing-session refresh mechanism to
CategoryTokensNotifierto recreate sessions before TTL expiry.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/ion_token_analytics/lib/src/community_tokens/latest_tokens/latest_tokens_repository_impl.dart | Prevents empty type query param from being sent to latest tokens endpoints. |
| lib/app/features/user/pages/creator_tokens/views/creator_tokens_page/components/tabs/creator_tokens_tab_content.dart | Adds docs clarifying that token type filtering is backend-driven. |
| lib/app/features/user/pages/creator_tokens/models/token_type_filter.dart | Updates the backend type query param values used by creator/content/x filters. |
| lib/app/features/tokenized_communities/providers/category_tokens_provider.r.dart | Adds TTL-based timer to refresh viewing sessions and resubscribes to realtime updates. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+40
to
+46
| /// TTL from API: typically seconds (e.g. 300 = 5 min); | ||
| void _scheduleSessionRecreate(ViewingSession session) { | ||
| _sessionExpiryTimer?.cancel(); | ||
| _sessionExpiryTimer = null; | ||
| final ttlSec = session.ttl >= 1000 ? session.ttl ~/ 1000 : session.ttl; | ||
| final refreshInSec = (ttlSec - _sessionRefreshBeforeExpirySec).clamp(1, ttlSec); | ||
| _sessionExpiryTimer = Timer(Duration(seconds: refreshInSec), () { |
Comment on lines
+21
to
+22
| /// [requestType] is sent to the analytics API for category (Trending/Top) and | ||
| /// latest endpoints; the UI shows [state.activeItems] with no client-side filtering. |
ice-orion
reviewed
Mar 16, 2026
| _sessionExpiryTimer?.cancel(); | ||
| _sessionExpiryTimer = null; | ||
| final ttlSec = session.ttl >= 1000 ? session.ttl ~/ 1000 : session.ttl; | ||
| final refreshInSec = (ttlSec - _sessionRefreshBeforeExpirySec).clamp(1, ttlSec); |
Contributor
There was a problem hiding this comment.
Is there a reason we refresh the token exactly 30 seconds before it expires?
ice-morpheus
force-pushed
the
bugfix/tc-filter-creator-tokens-by-type
branch
from
e735c08 to
eb37d4b
Compare
ice-orion
reviewed
Mar 16, 2026
| _type = type; | ||
|
|
||
| ref.onDispose(() async { | ||
| _disposed = true; |
Contributor
There was a problem hiding this comment.
Don't we have an issue with this _disposed - u set it to true but u never reset it.
ref.onDispose is called, for example, when a dependency is changed and the same instance is used, so the provider will remain in _disposed->true state in this case.
And why do we need this flag in the first place? The only place where it is used is in the Timer callback and u cancel all the timers in the same place u set this flag, so isn't it redundant?
ice-morpheus
force-pushed
the
bugfix/tc-filter-creator-tokens-by-type
branch
4 times, most recently
from
7dd5472 to
d5c619d
Compare
ice-morpheus
force-pushed
the
bugfix/tc-filter-creator-tokens-by-type
branch
28 times, most recently
from
3478443 to
40dfa5a
Compare
ice-morpheus
force-pushed
the
bugfix/tc-filter-creator-tokens-by-type
branch
from
40dfa5a to
5904dcf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pass right type param, add session ttl handling, fix stale sessionId initialization
Task ID
related to ION-5729
Type of Change