Skip to content

feat(wallet/swap): swap price impact calculation + more info about swap#3626

Open
ice-brontes wants to merge 12 commits into
masterfrom
feat/swap-price-impact-calculation
Open

feat(wallet/swap): swap price impact calculation + more info about swap#3626
ice-brontes wants to merge 12 commits into
masterfrom
feat/swap-price-impact-calculation

Conversation

@ice-brontes

Copy link
Copy Markdown
Contributor

Description

Implement price impact calculation to use spot price vs execution price formula.

Additional Notes

Also, added expand/collapse animation for the swap info.

Task ID

ION-4738

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Documentation
  • Chore

Screenshots (if applicable)

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2026-03-09.at.21.33.18.mp4

@ice-brontes ice-brontes marked this pull request as ready for review March 10, 2026 06:13
@ice-brontes ice-brontes requested review from a team as code owners March 10, 2026 06:13
@ice-morpheus ice-morpheus enabled auto-merge (squash) March 10, 2026 06:13
ice-kreios
ice-kreios previously approved these changes Mar 10, 2026
@ice-morpheus ice-morpheus force-pushed the feat/swap-price-impact-calculation branch 3 times, most recently from 6f637c5 to 0ef1486 Compare March 10, 2026 07:48
@ice-brontes ice-brontes force-pushed the feat/swap-price-impact-calculation branch from 0ef1486 to 85b52fb Compare March 10, 2026 08:21
@ice-morpheus ice-morpheus force-pushed the feat/swap-price-impact-calculation branch 2 times, most recently from 70224a3 to d4c2701 Compare March 10, 2026 08:52
@ice-brontes ice-brontes force-pushed the feat/swap-price-impact-calculation branch from d4c2701 to 8632efa Compare March 10, 2026 08:54
@ice-morpheus ice-morpheus force-pushed the feat/swap-price-impact-calculation branch 6 times, most recently from 80cee9e to c20ff0c Compare March 10, 2026 14:43
ice-priapus
ice-priapus previously approved these changes Mar 10, 2026
@ice-morpheus ice-morpheus force-pushed the feat/swap-price-impact-calculation branch 9 times, most recently from 5e5df61 to c7577aa Compare March 11, 2026 14:50
@ice-brontes ice-brontes dismissed stale reviews from ice-tychon and ice-kreios via b9f1169 March 17, 2026 10:37
@ice-brontes ice-brontes force-pushed the feat/swap-price-impact-calculation branch 2 times, most recently from b9f1169 to 9684c95 Compare March 17, 2026 10:38
ice-priapus
ice-priapus previously approved these changes Mar 17, 2026
@ice-morpheus ice-morpheus force-pushed the feat/swap-price-impact-calculation branch from 9684c95 to c72a29c Compare March 17, 2026 10:45
ice-tychon
ice-tychon previously approved these changes Mar 17, 2026
@ice-morpheus ice-morpheus force-pushed the feat/swap-price-impact-calculation branch 7 times, most recently from ca436d4 to b4eaf15 Compare March 18, 2026 10:44
ice-erebus
ice-erebus previously approved these changes Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants