feat: invalidate token market info after successful swap#3514
Draft
ice-priapus wants to merge 1 commit into
Draft
feat: invalidate token market info after successful swap#3514ice-priapus wants to merge 1 commit into
ice-priapus wants to merge 1 commit into
Conversation
ice-priapus
requested review from
ice-kreios,
ice-neoptolemus and
ice-tychon
ice-morpheus
force-pushed
the
bugfix/update_token_market_info_after_swap
branch
from
39fbfe8 to
c7f009d
Compare
ice-phobos
reviewed
Feb 26, 2026
| ref.invalidate(walletViewsDataNotifierProvider); | ||
| _invalidateUserHoldings(ref); | ||
| // Refetch market data (including position) for the token we just bought or sold. | ||
| ref.invalidate(tokenMarketInfoProvider(resolvedExternalAddress)); |
Contributor
There was a problem hiding this comment.
Shouldn't btw tokenMarketInfoProvider theoretically update us about any changes via SSE subscription we have inside? Just curios 🤔
As we have both Get request & SSE subscription, but we behave here as we use only Get :)
ice-phobos
approved these changes
Feb 26, 2026
ice-morpheus
force-pushed
the
bugfix/update_token_market_info_after_swap
branch
from
c7f009d to
12a0c59
Compare
ice-neoptolemus
approved these changes
Feb 27, 2026
ice-morpheus
force-pushed
the
bugfix/update_token_market_info_after_swap
branch
from
12a0c59 to
776fcdc
Compare
ice-tychon
approved these changes
Feb 27, 2026
ice-morpheus
force-pushed
the
bugfix/update_token_market_info_after_swap
branch
7 times, most recently
from
4d75f16 to
2f64500
Compare
ice-morpheus
force-pushed
the
bugfix/update_token_market_info_after_swap
branch
from
2f64500 to
51fe375
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
invalidating the token market info after successful TC swap
Additional Notes
this should help with cases when balance info is missing for creator or content token
the issue in the task was pretty hard to reproduce, so this change is mostly a possible improvement that should help
Task ID
ION-5638
Type of Change
Screenshots (if applicable)