dedicated pr with history / balance from indexer #383
Open
ice-cronus wants to merge 33 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a dedicated ion-indexer package to centralize interactions with the Ion blockchain indexer API, extracting NFT listing functionality from nft-content and adding new wallet transaction history and balance capabilities. The refactoring improves code organization by separating indexer-specific logic into its own package while maintaining backward compatibility through fallback mechanisms.
Key Changes:
- Created new
ion-indexerpackage with NFT listing, wallet transactions, and balance retrieval - Added two new API endpoints:
/wallets/{walletId}/historyand/wallets/{walletId}/assets - Refactored
storage.MustConnectsignature to swap parameter order for better consistency - Changed pagination limits from
uinttouint64throughout the codebase for larger datasets
Reviewed changes
Copilot reviewed 33 out of 34 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
ion-indexer/*.go |
New package implementing indexer client with NFT, transaction history, and balance operations |
nft-content/indexer.go |
Deleted - functionality moved to ion-indexer package |
accounts/wallets.go |
Added GetWalletHistory and GetWalletAssets methods with indexer integration and fallback |
cmd/heimdall-identity-io/delegated_rp.go |
Added new endpoints for wallet history and assets |
coins/DDL.sql |
Updated coin names to add "(OLD)" suffix for legacy ICE tokens |
relay-management/, following/, etc. |
Updated storage.MustConnect calls to use new signature |
.github/workflows/CICD.yaml |
Modified workflow triggers and disabled deployment step |
go.mod, go.sum |
Updated Go version to 1.25.5 and various dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
(cherry picked from commit b3f799e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.