Skip to content

Fixed to match from zone with larger string length.#63

Open
hokupod wants to merge 2 commits into
icamys:masterfrom
hokupod:master
Open

Fixed to match from zone with larger string length.#63
hokupod wants to merge 2 commits into
icamys:masterfrom
hokupod:master

Conversation

@hokupod

@hokupod hokupod commented Mar 10, 2022

Copy link
Copy Markdown

Changed parserFor method to match from zone with larger character length.
This change was made to ensure that ".co.jp" is selected instead of the zone name ".jp" if the domain name is "example.co.jp".

Regards.

@icamys

icamys commented Mar 10, 2022

Copy link
Copy Markdown
Owner

@hokupod Thank you for this upgrade. Could you please add a test that will cover this change?

@hokupod

hokupod commented Mar 11, 2022

Copy link
Copy Markdown
Author

@icamys
Thank you for your review.
Please wait while we add a test of the changes.

@hokupod

hokupod commented Mar 11, 2022

Copy link
Copy Markdown
Author

@icamys
Added test for parserFor().
Please review.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants