ci: add .dockerignore (keep docs/agent/VCS files out of the SPA build)#136
Merged
Conversation
The builder does `COPY . .` and Next.js standalone file-tracing walks the project and follows symlinks. A dangling doc symlink (CLAUDE.md, fixed separately) crashed `next build` with ENOENT. Excluding files the build doesn't need (CLAUDE.md/AGENTS.md/docs/.claude/.github/*.md, node_modules, .next, .git) removes that whole class of foot-gun and shrinks the context. Verified nothing in next.config or src reads the excluded paths. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
Claude finished @bnsoni's task —— View job E2E Coverage Review
✅ E2E Coverage — No IssuesNo new app routes were introduced (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a
.dockerignore(neither repo had one) so the SPA Docker build excludes files it does not need.Why
The builder runs
COPY . .and Next.js (output: 'standalone') file-tracing walks the whole project and follows symlinks. A dangling doc symlink (CLAUDE.md → "AGENTS.md\n", a stray newline — fixed separately) crashednext build:Keeping docs/agent/VCS files out of the build context removes that whole class of foot-gun (any future dangling doc symlink can no longer reach the build) and shrinks the context/image.
Excluded (verified not needed by the build)
CLAUDE.md,AGENTS.md,.claude/,.github/,docs/, root*.md, editor dirs,node_modules,.next,.git.Verified nothing in
next.configor app source reads these; the runner image only copies.nextoutput +public/+server-wrapper.js/entrypoint.sh, none of which are excluded. Excludingnode_modulesis also protective — it stops a localnode_modulesfrom overwriting the freshly-installed one duringCOPY . ..🤖 Generated with Claude Code