Skip to content

fix issue #12 timeout is not forwarding it's source #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnzsnz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix issue #12 timeout is not forwarding it's source #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eventkit/ops/timing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def __init__(self, timeout, source=None):
def on_source(self, *args):
loop = get_event_loop()
self._last_time = loop.time()
Op.on_source(self, *args)

def on_source_done(self, source):
self._handle.cancel()
Expand Down
7 changes: 7 additions & 0 deletions tests/timing_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,13 @@ def test_sample(self):
self.assertEqual(event.run(), [2, 4, 6, 8])

def test_timeout(self):
# source faster than timeout
seq = Event.sequence(array1, interval=0.01).timeout(0.1)
self.assertEqual(seq.run(), array1)
# source slower than timeout
seq2 = Event.sequence([1, 2, 3], interval=0.1).timeout(0.01)
self.assertEqual(seq2.run(), [1, Event.NO_VALUE])
# plain timeout
timer = Event.timer(10, count=1)
event = timer.timeout(0.01)
self.assertEqual(event.run(), [Event.NO_VALUE])
Expand Down