remove() end early

[singingwolfboy]

I was having a problem while using Squire.js with my test suite, where the context was undefined when I called injector.remove(). This modification fixed it. I also removed trailing whitespace in a separate commit.

[iammerrick]

Could you please example the problem better?

[fearphage]

The problem is Squire throws if remove() is called when there is nothing to remove. new Squire().remove() should not throw. It currently does.

[fearphage]

I also noticed remove is not tested at all. Might explain the issue. @singingwolfboy mind adding tests?

[fearphage]

The same is true for clean(). new Squire().clean() throws because the context is undefined.

[iammerrick]

@singingwolfboy Could you add a test around this? I'm struggling to know when you wouldn't have a context?

[RLovelett]

I can't exactly explain why context is ending up undefined (yet). I can however say this does fix the issue.

[RLovelett]

@iammerrick The issue was that inside of Squire#remove there is a call to completely destroy the current Squire.js context that RequireJS was managing. This context was the context created during the constructor of the Squire instance.

I have proposed a solution, in pull request #49. The solution implemented in this patch is to rebuild a new RequireJS context, after deleting the initial context. This way the RequireJS context is fresh, as the remove call would indicate it should be, while also still being defined for subsequent calls.

Additionally, there should no longer be an edge case that leads to the context being undefined in the first place, as was the initial symptom of the issue.

[shustariov-andrey]

Having the same issue. And this pull request fixes it in my case.