fix: restore Codex CLI compatibility with current config schema#50
Conversation
Remove the stale tools.web_search=false override Codex no longer accepts, and default Codex reasoning effort to low so it works with current CLI behavior. Also update the bundled codex profile default accordingly. Supersedes #47 (thanks @BorisEagle). Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f10da9551
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cmd.arg("-c"); | ||
| cmd.arg(format!("model_reasoning_effort={}", reasoning)); | ||
| cmd.arg("-c"); | ||
| cmd.arg("sandbox_mode=read-only"); |
There was a problem hiding this comment.
In the Codex CLI path, this change now only applies the read-only filesystem sandbox and no longer disables web search. OpenAI's Codex config reference documents web_search as defaulting to cached search and says disabled removes the tool (https://developers.openai.com/codex/config-reference), so qq --profile codex or qa --profile codex can still let Codex issue search queries for user prompts that qqqa otherwise treats as no-tool/read-only. Please replace the removed legacy override with the current top-level disable setting, e.g. a -c web_search=disabled override, rather than omitting it entirely.
Useful? React with 👍 / 👎.
1 participant
Summary
tools.web_search=falseCodex config override (current Codex CLI expects a struct, not a boolean).lowinstead ofminimal, matching current Codex CLI constraints.codexprofile default and CLI backend test expectations.Supersedes #47 — thanks @BorisEagle for reporting and the initial patch.
Test plan
cargo testqq --profile codex "list files here"Made with Cursor