feat: add Snap Store badge and web app URL in README and landing pages#7
Conversation
Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe landing pages now render Snap Store downloads with Snapcraft badges, Linux releases include Red Hat RPM selection, macOS detection uses cached explicit user-agent architecture signals, and the README adds Snapcraft and Web Version links. ChangesDownload access
Estimated code review effort: 3 (Moderate) | ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@teebot_flow_landing_premium.html`:
- Around line 210-212: Update the Snap Store anchor in
teebot_flow_landing_premium.html to include target="_blank" and rel="noopener
noreferrer", matching the behavior of the surrounding external download links
while preserving the existing href and image content.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 2679b8cd-6626-4e37-bfec-7393b51d5151
📒 Files selected for processing (3)
README.mdsrc/pages/LandingPage.tsxteebot_flow_landing_premium.html
Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
…ding page Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
…to bypass masked user-agents Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
…t action Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/lib/platform.ts (2)
59-88: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick winFail closed on ambiguous macOS architecture detection.
WEBGL_debug_renderer_infois a GPU hint, not a CPU-arch signal, and Apple Silicon UAs can still reportIntel Mac OS X. Returningaarch64/x64from these strings can send users to the wrong installer; returnnullunless the signal is explicit, and add coverage for masked WebGL and reduced/spoofed UAs.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/platform.ts` around lines 59 - 88, Update the platform architecture detection function around the WebGL renderer and user-agent checks to fail closed: do not infer CPU architecture from Apple/M-series GPU names or generic Intel/x64 UA strings. Return “aarch64” or “x64” only for explicit, trustworthy architecture signals; otherwise return null. Add coverage for masked WebGL renderer data and reduced or spoofed macOS user agents.Source: MCP tools
48-48: 🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick winFix the RPM asset name
src/lib/platform.ts:48, 117-120Tauri’s RPM bundle name uses the normalized product name, so this should be
teebot-flow-${version}-1.x86_64.rpm, notTeebot.Flow-${version}-1.x86_64.rpm; otherwise the RPM download link will 404.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/platform.ts` at line 48, Update the rpm asset-name template in the platform configuration to use the normalized lowercase hyphenated product name, producing teebot-flow-${version}-1.x86_64.rpm instead of the current Teebot.Flow form. Keep the existing version and architecture suffix unchanged.
🧹 Nitpick comments (1)
src/lib/platform.ts (1)
60-63: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick winCache the architecture detection result.
LandingPagecalls this path during render, so every re-render creates a new canvas and WebGL context. Cache the result once per browser session, or perform detection once outside the render path, to avoid repeated setup and resource churn.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/platform.ts` around lines 60 - 63, Update the architecture detection flow around the canvas/WebGL setup in platform detection to cache the computed result for the browser session or initialize it outside the render path. Ensure subsequent LandingPage renders reuse the cached value without creating another canvas or WebGL context.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/lib/platform.ts`:
- Around line 59-88: Update the platform architecture detection function around
the WebGL renderer and user-agent checks to fail closed: do not infer CPU
architecture from Apple/M-series GPU names or generic Intel/x64 UA strings.
Return “aarch64” or “x64” only for explicit, trustworthy architecture signals;
otherwise return null. Add coverage for masked WebGL renderer data and reduced
or spoofed macOS user agents.
- Line 48: Update the rpm asset-name template in the platform configuration to
use the normalized lowercase hyphenated product name, producing
teebot-flow-${version}-1.x86_64.rpm instead of the current Teebot.Flow form.
Keep the existing version and architecture suffix unchanged.
---
Nitpick comments:
In `@src/lib/platform.ts`:
- Around line 60-63: Update the architecture detection flow around the
canvas/WebGL setup in platform detection to cache the computed result for the
browser session or initialize it outside the render path. Ensure subsequent
LandingPage renders reuse the cached value without creating another canvas or
WebGL context.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/platform.ts`:
- Around line 138-165: Update the download-selection logic around
detectLinuxDistro so only the explicit "debian" result selects the .deb asset,
while "generic" routes to the releases page or another explicitly generic
option; keep "redhat" mapped to its existing asset.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
|
@coderabbitai resume |
✅ Action performedReviews resumed. |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/lib/platform.ts (1)
56-120: 🎯 Functional Correctness | 🔵 Trivial | 💤 Low valueRemove or complete the WebGL fallback
The canvas/WebGL probe only ever short-circuits to
null; it never produces an"aarch64"or"x64"result, so it doesn’t affect the chosen download. If this is meant to be fail-closed only, drop the block; otherwise add a real renderer→architecture mapping here.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/lib/platform.ts` around lines 56 - 120, Remove the ineffective canvas/WebGL probe from getMacArch, since it only returns null and never selects an architecture. Preserve the existing cachedMacArch handling, explicit User-Agent detection, and final fail-closed null fallback.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/lib/platform.ts`:
- Around line 221-233: Update the Linux branch in the platform download
selection to handle the “generic” result from detectLinuxDistro() explicitly
instead of falling through to the Debian package. Preserve the existing RedHat
RPM behavior and Debian-specific DEB behavior, and provide a safe generic-Linux
fallback that does not assume a package format.
---
Nitpick comments:
In `@src/lib/platform.ts`:
- Around line 56-120: Remove the ineffective canvas/WebGL probe from getMacArch,
since it only returns null and never selects an architecture. Preserve the
existing cachedMacArch handling, explicit User-Agent detection, and final
fail-closed null fallback.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
…llback Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
1 participant
Summary by CodeRabbit