fix: use canonical/setup-lxd for snapcraft networking and disable dra…#5
Conversation
…ft releases to auto-publish Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe release workflow publishes desktop releases immediately and replaces manual LXD initialization in the Linux snap job with the ChangesRelease workflow
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/release.yml (1)
142-152: 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy liftPublishing the release on the first matrix leg exposes an incomplete release.
release-desktopruns as a matrix (macOS arm64/x64, Linux, Windows) withfail-fast: false, and each leg callstauri-apps/tauri-actionagainst the sametagName. WithreleaseDraft: false, the very first leg to finish will create/publish the GitHub Release immediately — before the other platform artifacts finish uploading, and before the separaterelease-linux-snapjob (which itself assumes "Release may not exist yet (created by desktop job)" at Line 235) attaches the.snapasset. Watchers/subscribers will be notified of a release that is still missing artifacts.Consider keeping the release in draft until all matrix legs and the snap job complete (e.g., a follow-up job that flips
releaseDrafttofalse/publishes only after allneeds:dependencies succeed), rather than publishing on first completion.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/release.yml around lines 142 - 152, Keep the release created by the tauri action in draft state instead of publishing it from the first release-desktop matrix leg. Update the workflow around the release-desktop and release-linux-snap jobs to add a final publish step that depends on all matrix legs and the snap job succeeding, then publish the existing release only after every platform artifact is attached.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 200-204: Update the release workflow around the “Setup LXD” step
to explicitly grant the runner user membership in the lxd group before the
snapcraft packing command invokes sg lxd. Preserve the existing LXD setup and
ensure the membership change applies to the subsequent pack step.
---
Outside diff comments:
In @.github/workflows/release.yml:
- Around line 142-152: Keep the release created by the tauri action in draft
state instead of publishing it from the first release-desktop matrix leg. Update
the workflow around the release-desktop and release-linux-snap jobs to add a
final publish step that depends on all matrix legs and the snap job succeeding,
then publish the existing release only after every platform artifact is
attached.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: dbeb2a76-c5ee-4775-afa9-9c8797b4887d
📒 Files selected for processing (1)
.github/workflows/release.yml
Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
…ft releases to auto-publish
Summary by CodeRabbit