Skip to content

fix: use canonical/setup-lxd for snapcraft networking and disable dra…#5

Merged
AteebNoOne merged 2 commits into
mainfrom
fix/lxd-publish
Jul 12, 2026
Merged

fix: use canonical/setup-lxd for snapcraft networking and disable dra…#5
AteebNoOne merged 2 commits into
mainfrom
fix/lxd-publish

Conversation

@AteebNoOne

@AteebNoOne AteebNoOne commented Jul 12, 2026

Copy link
Copy Markdown
Member

…ft releases to auto-publish

Summary by CodeRabbit

  • Release Improvements
    • Desktop releases are now published immediately instead of remaining in draft status.
    • Linux snap releases use an updated build environment setup, improving release consistency and reliability.

…ft releases to auto-publish

Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
teebot-flow Ready Ready Preview, Comment Jul 12, 2026 12:50am

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 3fb9a3e3-2c1a-410e-a480-24107a055709

📥 Commits

Reviewing files that changed from the base of the PR and between 968efe6 and 531b25a.

📒 Files selected for processing (1)
  • .github/workflows/release.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/release.yml

📝 Walkthrough

Walkthrough

The release workflow publishes desktop releases immediately and replaces manual LXD initialization in the Linux snap job with the canonical/setup-lxd@v1 action.

Changes

Release workflow

Layer / File(s) Summary
Desktop release publication
.github/workflows/release.yml
Changes the Tauri release action from draft creation to immediate publication.
Linux snap environment setup
.github/workflows/release.yml
Separates snapcraft installation from LXD setup and uses canonical/setup-lxd@v1 instead of manual initialization.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: switching Snapcraft networking to canonical/setup-lxd and disabling draft releases.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lxd-publish

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
.github/workflows/release.yml (1)

142-152: 🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift

Publishing the release on the first matrix leg exposes an incomplete release.

release-desktop runs as a matrix (macOS arm64/x64, Linux, Windows) with fail-fast: false, and each leg calls tauri-apps/tauri-action against the same tagName. With releaseDraft: false, the very first leg to finish will create/publish the GitHub Release immediately — before the other platform artifacts finish uploading, and before the separate release-linux-snap job (which itself assumes "Release may not exist yet (created by desktop job)" at Line 235) attaches the .snap asset. Watchers/subscribers will be notified of a release that is still missing artifacts.

Consider keeping the release in draft until all matrix legs and the snap job complete (e.g., a follow-up job that flips releaseDraft to false/publishes only after all needs: dependencies succeed), rather than publishing on first completion.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml around lines 142 - 152, Keep the release
created by the tauri action in draft state instead of publishing it from the
first release-desktop matrix leg. Update the workflow around the release-desktop
and release-linux-snap jobs to add a final publish step that depends on all
matrix legs and the snap job succeeding, then publish the existing release only
after every platform artifact is attached.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/release.yml:
- Around line 200-204: Update the release workflow around the “Setup LXD” step
to explicitly grant the runner user membership in the lxd group before the
snapcraft packing command invokes sg lxd. Preserve the existing LXD setup and
ensure the membership change applies to the subsequent pack step.

---

Outside diff comments:
In @.github/workflows/release.yml:
- Around line 142-152: Keep the release created by the tauri action in draft
state instead of publishing it from the first release-desktop matrix leg. Update
the workflow around the release-desktop and release-linux-snap jobs to add a
final publish step that depends on all matrix legs and the snap job succeeding,
then publish the existing release only after every platform artifact is
attached.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dbeb2a76-c5ee-4775-afa9-9c8797b4887d

📥 Commits

Reviewing files that changed from the base of the PR and between 9ac2dc2 and 968efe6.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Comment thread .github/workflows/release.yml
Co-authored-by: Atib Ur Rehman <rehmanateebur@gmail.com>
@AteebNoOne AteebNoOne merged commit b6fd5c1 into main Jul 12, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant