This repository was archived by the owner on Nov 21, 2024. It is now read-only.
no replacement of nonnumberic characters by _ in AndroidLayoutFile ma…#17
Open
SilviaHT wants to merge 1 commit into
Open
no replacement of nonnumberic characters by _ in AndroidLayoutFile ma…#17SilviaHT wants to merge 1 commit into
SilviaHT wants to merge 1 commit into
Conversation
Contributor
ehoogerbeets
left a comment
ehoogerbeets
left a comment
There was a problem hiding this comment.
The code that is here looks pretty good. We still need the part in the localize method where we look up the translations by the key, and if it is not there, try again with the old key.
| var unescaped = string; | ||
|
|
||
| while ((match = reUnicodeChar.exec(unescaped))) { | ||
| if (match && match.length > 1) { |
Contributor
There was a problem hiding this comment.
Are unicode and octal escape sequences even valid in the Android layout xml files?
Contributor
|
Also, we need to fix up the unit tests of course so that the build passes. |
Contributor
|
Silvia, are you still working on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…keKey function