Fix TUI tool-call argument rendering#9
Merged
Merged
Conversation
Tool calls arrive through several LangChain and DeepAgents shapes, including partial tool_call_chunks and later updates snapshots. The TUI now normalizes those shapes, accumulates argument fragments, and keeps message segments from bleeding across tool boundaries. Constraint: LangChain streams tool-call arguments through partial chunks and may only provide complete arguments in updates snapshots Rejected: Only display arguments from token.tool_calls | real streams often expose empty args there Rejected: Treat result text containing Error as failure | source files can legitimately contain that text Confidence: high Scope-risk: moderate Directive: Keep tool-call argument handling covered by stream_handler regression tests before changing accumulator behavior Tested: uv run pytest tests/tui/test_stream_handler.py -q --no-cov Tested: uv run pytest Not-tested: Manual TUI session after commit Co-authored-by: OmX <omx@oh-my-codex.dev>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bfd2e3d66e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests