chore: 🤖 update dependencies and add support for env config files - #10
Conversation
📝 WalkthroughWalkthroughThis PR adds support for environment-based config file discovery by extending the config loader's search locations to include Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@package.json`:
- Around line 52-78: package.json updates bump several packages with breaking
changes (notably vitest to 4.0, commitlint to 20.x, and `@types/node` to 25.x);
run the full test suite and CI locally and update configs: audit and update
vitest config keys and options (remove deprecated keys like
poolMatchGlobs/environmentMatchGlobs, migrate deps.external/inline/fallbackCJS
and reporter hooks usage, adjust coverage remapping and browser provider
config), update tests that rely on vi mocking/spy semantics (replace/adjust uses
of vi.fn().getMockName(), vi.restoreAllMocks() assumptions and automock
behavior), tweak commitlint rules if you relied on body-max-line-length for
URLs, and verify TypeScript/Node typings with `@types/node`@25; if immediate
compatibility fixes are nontrivial, pin the previous working versions in
package.json (restore vitest/commitlint/@types/node) until tests and configs are
updated and CI passes.
🧹 Nitpick comments (1)
src/config-loader/searchConfig.ts (1)
29-35: Consider adding.mtsvariant for the rc-style TypeScript config.For consistency, the rc-style TypeScript config (line 30) has only
.tswhile the regular config has both.tsand.mts(lines 31-32). The new env configs follow the latter pattern with both extensions. You might want to add.${moduleName}rc.mtsto maintain consistency across all TypeScript config patterns.♻️ Optional consistency improvement
// TS `.${moduleName}rc.ts`, + `.${moduleName}rc.mts`, `${moduleName}.config.ts`, `${moduleName}.config.mts`, // ENV `env.${moduleName}.ts`, `env.${moduleName}.mts`,
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (9)
.changeset/silly-pillows-rescue.mdpackage.jsonsrc/config-loader/searchConfig.tstests/config-loader/esm-ts.spec.tstests/config-loader/fixtures/esm-ts/env-mts-test/env.valid.mtstests/config-loader/fixtures/esm-ts/env-test/env.valid.mtstests/config-loader/fixtures/esm-ts/env-test/env.valid.tstests/config-loader/fixtures/esm-ts/env.valid.mtstests/config-loader/fixtures/esm-ts/env.valid.ts
🧰 Additional context used
🧬 Code graph analysis (1)
tests/config-loader/esm-ts.spec.ts (2)
src/config-loader/loadConfig.ts (1)
loadConfig(6-21)src/config-loader/searchConfig.ts (1)
searchConfig(11-42)
🔇 Additional comments (9)
tests/config-loader/fixtures/esm-ts/env.valid.mts (1)
1-4: LGTM!Simple and well-structured test fixture for validating
.mtsenvironment config file loading..changeset/silly-pillows-rescue.md (1)
1-5: LGTM!Patch release level is appropriate for this additive, non-breaking feature. The description accurately captures the scope of changes.
tests/config-loader/fixtures/esm-ts/env.valid.ts (1)
1-4: LGTM!Clean fixture for validating
.tsenvironment config file loading.src/config-loader/searchConfig.ts (1)
33-35: LGTM!The new environment config search locations are consistent with existing TypeScript patterns (no
.ctsvariant, matching lines 30-32). The placement at the end of the search order is reasonable.tests/config-loader/fixtures/esm-ts/env-mts-test/env.valid.mts (1)
1-4: LGTM!Clean fixture for testing
searchConfigwith.mtsenvironment config files in a dedicated test directory.tests/config-loader/fixtures/esm-ts/env-test/env.valid.ts (1)
1-4: LGTM!Clean test fixture that follows the established pattern for config files in this test suite. The distinct value
'a lie env'allows tests to verify the correct file is being loaded.tests/config-loader/fixtures/esm-ts/env-test/env.valid.mts (1)
1-4: LGTM!Properly structured
.mtsfixture with a distinct value that enables testing the fallback behavior when.tsvariant doesn't exist.tests/config-loader/esm-ts.spec.ts (2)
45-59: LGTM!Good test coverage for direct loading of both
.tsand.mtsenv config files. The tests follow the established pattern and correctly validate the expected config values.
103-119: Good coverage for env config search functionality.The tests properly validate both the
.tsenv config discovery and the.mtsfallback when.tsdoesn't exist. The test directory setup is correct:env-testcontains both.tsand.mtsfiles (search priority), whileenv-mts-testcontains only the.mtsfile, ensuring the fallback behavior is properly tested.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
| "dependencies": { | ||
| "@hyperse/deep-merge": "^1.0.1", | ||
| "@hyperse/unplugin-swc": "^1.0.1", | ||
| "@hyperse/unplugin-swc": "^1.0.2", | ||
| "@manypkg/get-packages": "^3.1.0", | ||
| "@swc/core": "^1.13.5", | ||
| "@swc/core": "^1.15.8", | ||
| "cosmiconfig": "^9.0.0", | ||
| "get-tsconfig": "^4.10.1" | ||
| "get-tsconfig": "^4.13.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@changesets/changelog-github": "^0.5.1", | ||
| "@changesets/cli": "^2.29.7", | ||
| "@commitlint/cli": "^19.8.1", | ||
| "@commitlint/config-conventional": "^19.8.1", | ||
| "@hyperse/eslint-config-hyperse": "^1.4.8", | ||
| "@types/node": "^24.5.2", | ||
| "@changesets/changelog-github": "^0.5.2", | ||
| "@changesets/cli": "^2.29.8", | ||
| "@commitlint/cli": "^20.3.1", | ||
| "@commitlint/config-conventional": "^20.3.1", | ||
| "@hyperse/eslint-config-hyperse": "^1.5.0", | ||
| "@types/node": "^25.0.8", | ||
| "commitizen": "^4.3.1", | ||
| "cz-conventional-changelog": "^3.3.0", | ||
| "eslint": "^9.36.0", | ||
| "execa": "^9.6.0", | ||
| "eslint": "^9.39.2", | ||
| "execa": "^9.6.1", | ||
| "husky": "^9.1.7", | ||
| "lint-staged": "^16.1.6", | ||
| "lint-staged": "^16.2.7", | ||
| "npm-run-all": "^4.1.5", | ||
| "rollup": "^4.52.0", | ||
| "tsup": "^8.5.0", | ||
| "typescript": "^5.9.2", | ||
| "vitest": "^3.2.4" | ||
| "rollup": "^4.55.1", | ||
| "tsup": "^8.5.1", | ||
| "typescript": "^5.9.3", | ||
| "vitest": "^4.0.17" | ||
| }, |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
vitest 4.0 breaking changes migration guide
💡 Result:
Here are the main Vitest 4.0 breaking changes and the minimal migration actions you should take. See the official migration guide and release post for full details. [1][2]
-
V8 coverage remapping changed
- Expect different coverage numbers; no action unless you rely on v8-to-istanbul specifics. Validate reports and update CI thresholds if needed. [1]
-
Mocking / spies behavior changed
- vi.fn().getMockName() now defaults to no name (affects mock snapshots).
- vi.restoreAllMocks() no longer resets automocks (only restores spies from vi.spyOn); .mockRestore still clears implementations.
- vi.spyOn called on a mock returns the same mock.
- Update tests that relied on the previous restore/spy behaviors and snapshot names. [1]
-
Deprecated APIs removed — update config/tests to new options
- Replace poolMatchGlobs / environmentMatchGlobs with projects.
- Move deps.external/inline/fallbackCJS → server.deps.external/inline/fallbackCJS.
- Replace browser.testerScripts → browser.testerHtmlPath.
- Remove minWorkers (use maxWorkers only).
- Reporter hook APIs (onCollected, onSpecsCollected, onPathsCollected, onTaskUpdate, onFinished) removed — migrate to the new Reporters API. [1][5]
-
Browser mode / providers changes
- Browser provider config now uses objects (provider factories) instead of strings; provider packages are separate (e.g.
@vitest/browser-playwright). Update test config and imports accordingly. [5][2]
- Browser provider config now uses objects (provider factories) instead of strings; provider packages are separate (e.g.
-
Internal/entry changes
- vitest/execute entrypoint removed.
- __vitest_executor injection removed; moduleRunner injected instead.
- vite-node is no longer a dependency.
- Custom environments should provide viteEnvironment instead of transformMode. [1][5]
-
Other renames / env vars
- VITE_NODE_DEPS_MODULE_DIRECTORIES → VITEST_MODULE_DIRECTORIES.
- deps.optimizer.web → deps.optimizer.client (or custom name). [1]
-
Reporters / defaults
- Basic reporter removed; use equivalent default reporter config instead. [5]
Quick migration checklist
- Read your test run and coverage reports after upgrading. Adjust CI thresholds. [1]
- Search & update usages of removed config keys and APIs in vitest config and custom reporters. [1][5]
- Update mocks/spy-based tests that assume old vi.restoreAllMocks/vi.spyOn behaviors and snapshot names. [1]
- If you use Browser Mode, install the new provider packages and convert provider config to the new object/factory form. [5][2]
- Run full test suite and fix failures caused by API/behavior changes.
Sources:
- Vitest Migration Guide — "Migrating to Vitest 4.0". [Vitest docs]. [1]
- Vitest 4.0 release announcement / blog. [2]
Would you like a PR-ready patch (search-and-replace script) for your vitest config and common patterns?
🌐 Web query:
commitlint 20.0 breaking changes
💡 Result:
Summary — breaking change in commitlint v20.0.0 (released Sep 25, 2025)
- The rule body-max-line-length now ignores lines that contain URLs (so long URL lines no longer count toward the body max-line-length). [1][2]
Impact and migration
- If you relied on body-max-line-length to enforce max length for all body lines (including URL lines), update your checks or add a custom rule to re-include URL lines. Otherwise no other major breaking changes were listed in the v20.0.0 release. [1][2]
Sources
- commitlint v20.0.0 release notes (GitHub). [1]
- commitlint npm/newreleases v20.0.0 summary. [2]
🌐 Web query:
@types/node 25 breaking changes
💡 Result:
Short answer: there’s no dedicated “@types/node v25 changelog.” Breaking/type changes for @types/node v25 mainly mirror Node.js v25 API changes (removed/EOLed APIs and new globals/DOM-ish APIs) and TypeScript-compatibility updates. Check these sources to see what will break and how to migrate:
- Node.js v25 release notes (lists semver‑major removals/changes that drive type changes — e.g. removal/finalization of SlowBuffer, global ErrorEvent, Web Storage enabled by default, new permissions like --allow-net). (nodejs.org)
- DefinitelyTyped discussion explaining there is no centralized
@types/nodechangelog and that you must inspect DT commits/PRs or the upstream Node changes. (github.com) @types/noderelease history / diffs (inspect specific@types/nodev25.x releases or use a package-diff/compare tool to see the exact .d.ts changes). Example release list. (releasealert.dev)
If you want, I can:
- List the specific Node v25 API changes most likely to affect your code (based on your codebase, e.g. uses of SlowBuffer, global ErrorEvent, fs.Dir GC behavior, node:_internal modules).
- Produce a diff of your current
@types/nodeversion → v25 and highlight breaking type changes (I can fetch the two releases and summarize).
Citations:
- 1: https://nodejs.org/en/blog/release/v25.0.0?utm_source=openai
- 2: Where do I find a changelog for this @types/node? DefinitelyTyped/DefinitelyTyped#52998
- 3: https://releasealert.dev/npmjs/%40types/node?utm_source=openai
Verify vitest 4.0 compatibility — multiple breaking changes require attention.
The major version bumps here warrant careful testing:
-
vitest 4.0 has significant breaking changes: V8 coverage remapping (may affect CI thresholds), mocking/spy behavior changes (e.g.,
vi.fn().getMockName()defaults differ,vi.restoreAllMocks()no longer resets automocks), deprecated config keys removed (poolMatchGlobs,environmentMatchGlobs,deps.external/inline/fallbackCJS, reporter hooks API), browser mode provider changes, and removed internal APIs. Verify your test config and test suite runs cleanly. -
commitlint 20.x: One minor breaking change —
body-max-line-lengthnow ignores URLs. Update config if you relied on strict line length for URL lines. -
@types/node 25.x: Type-only update mirroring Node.js v25 API changes. Low risk for build tools; verify in CI.
Ensure CI passes with these updates before merging.
🤖 Prompt for AI Agents
In `@package.json` around lines 52 - 78, package.json updates bump several
packages with breaking changes (notably vitest to 4.0, commitlint to 20.x, and
`@types/node` to 25.x); run the full test suite and CI locally and update configs:
audit and update vitest config keys and options (remove deprecated keys like
poolMatchGlobs/environmentMatchGlobs, migrate deps.external/inline/fallbackCJS
and reporter hooks usage, adjust coverage remapping and browser provider
config), update tests that rely on vi mocking/spy semantics (replace/adjust uses
of vi.fn().getMockName(), vi.restoreAllMocks() assumptions and automock
behavior), tweak commitlint rules if you relied on body-max-line-length for
URLs, and verify TypeScript/Node typings with `@types/node`@25; if immediate
compatibility fixes are nontrivial, pin the previous working versions in
package.json (restore vitest/commitlint/@types/node) until tests and configs are
updated and CI passes.
2 participants
Summary by CodeRabbit
Release Notes
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.