fix: prevent command injection in git-changes-commit-message tool#8
Open
123mutouren321414 wants to merge 1 commit into
Open
fix: prevent command injection in git-changes-commit-message tool#8123mutouren321414 wants to merge 1 commit into
123mutouren321414 wants to merge 1 commit into
Conversation
Replace child_process.exec with execFile to avoid shell interpretation.
The previous implementation executed `cd ${cwd}` and git commands using
child_process.exec, which allows shell metacharacters in user-controlled
input (autoCommitPath) to be interpreted by the shell.
This change:
- removes the unsafe `cd ${cwd}` shell call
- replaces exec with execFile
- executes git commands using argument arrays
This prevents command injection while preserving the original functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace child_process.exec with execFile to avoid shell interpretation.
The previous implementation executed
cd ${cwd}and git commands using child_process.exec, which allows shell metacharacters in user-controlled input (autoCommitPath) to be interpreted by the shell.This change:
cd ${cwd}shell callThis prevents command injection while preserving the original functionality.