consensus synchronizer BFT deliverer initialization#984
Open
DorKatzelnick wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR wires a “boot config block” through the consensus synchronizer creation path and uses it to initialize the BFT deliverer configuration during synchronization.
Changes:
- Extend
SynchronizerFactory.CreateSynchronizer(...)andnewSynchronizer(...)to accept and propagate abootConfigBlock. - Add
BootConfigBlocktoBFTSynchronizerand use it when extracting config forBFTDeliverer.Initialize(...). - Update synchronizer tests and refresh generated mock
Invocations()implementations.
Reviewed changes
Copilot reviewed 4 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| node/consensus/synchronizer/synchronizer_factory.go | Plumbs bootConfigBlock through synchronizer factory/creator into BFTSynchronizer. |
| node/consensus/synchronizer/synchronizer_bft.go | Uses BootConfigBlock to derive config for BFT deliverer initialization. |
| node/consensus/synchronizer/synchronizer_bft_test.go | Updates BFT synchronizer tests to set BootConfigBlock. |
| node/consensus/synchronizer/mocks/verifier_factory.go | Updates generated fake Invocations() locking behavior. |
| node/consensus/synchronizer/mocks/updatable_block_verifier.go | Updates generated fake Invocations() locking behavior. |
| node/consensus/synchronizer/mocks/orderer_config.go | Updates generated fake Invocations() locking behavior. |
| node/consensus/synchronizer/mocks/height_detector.go | Updates generated fake Invocations() locking behavior. |
| node/consensus/synchronizer/mocks/height_detector_factory.go | Updates generated fake Invocations() locking behavior. |
| node/consensus/synchronizer/mocks/consenter_support.go | Updates generated fake Invocations() locking behavior. |
| node/consensus/synchronizer/mocks/bft_deliverer_factory.go | Updates generated fake Invocations() locking behavior. |
| node/consensus/synchronizer/mocks/bft_block_deliverer.go | Updates generated fake Invocations() locking behavior. |
| node/consensus/consensus_builder.go | Passes lastConfigBlock into synchronizer creation as the boot config block. |
Files not reviewed (8)
- node/consensus/synchronizer/mocks/bft_block_deliverer.go: Generated file
- node/consensus/synchronizer/mocks/bft_deliverer_factory.go: Generated file
- node/consensus/synchronizer/mocks/consenter_support.go: Generated file
- node/consensus/synchronizer/mocks/height_detector.go: Generated file
- node/consensus/synchronizer/mocks/height_detector_factory.go: Generated file
- node/consensus/synchronizer/mocks/orderer_config.go: Generated file
- node/consensus/synchronizer/mocks/updatable_block_verifier.go: Generated file
- node/consensus/synchronizer/mocks/verifier_factory.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
HagarMeir
reviewed
Jul 5, 2026
| support ConsenterSupport, | ||
| bccsp bccsp.BCCSP, | ||
| clusterDialer *comm.PredicateDialer, | ||
| bootConfigBlock *cb.Block, |
Contributor
There was a problem hiding this comment.
maybe add some documentation
Contributor
Author
There was a problem hiding this comment.
added in synchronizer creation in consensus_builder
tock-ibm
force-pushed
the
consensusSyncBlock
branch
2 times, most recently
from
864757b to
000612a
Compare
HagarMeir
force-pushed
the
consensusSyncBlock
branch
from
000612a to
3e2ae9b
Compare
…onizer Signed-off-by: Dor.Katzelnick <Dor.Katzelnick@ibm.com>
DorKatzelnick
force-pushed
the
consensusSyncBlock
branch
from
3e2ae9b to
7fa4ae3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use boot config block to initialize BFT deliverer in consensus synchronizer
fix for #986