Assembler synchronizer#961
Open
DorKatzelnick wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces an “assembler synchronizer” implementation that can pull blocks from remote assembler endpoints using the existing BFT deliver-client machinery, and extends configuration parsing to surface assembler endpoint/TLS information.
Changes:
- Added
AssemblerInfoplus config extraction helpers (ExtractAssemblers,ExtractAssemblerAddresses) to obtain assembler endpoints and TLS CA roots from shared config. - Introduced a new
node/assembler/synchronizerpackage (factory, BFT sync logic, sync buffer, genesis fetcher factory, verifier abstraction) and generated mocks to support testing. - Wired an
assemblerSyncreplication policy path that constructs the new assembler BFT synchronizer.
Reviewed changes
Copilot reviewed 8 out of 16 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| node/config/config.go | Adds AssemblerInfo struct to represent assembler endpoint and TLS material. |
| config/config.go | Adds extraction of assemblers and assembler endpoint mapping from consensus metadata. |
| node/assembler/synchronizer/util.go | Adds adapters/factories for BFT deliverer creation and endpoint extraction. |
| node/assembler/synchronizer/synchronizer_factory.go | Adds factory that creates the assembler BFT synchronizer for assemblerSync policy. |
| node/assembler/synchronizer/synchronizer_bft.go | Implements the assembler BFT sync loop (genesis fetch + BFT deliverer + buffer pull/commit). |
| node/assembler/synchronizer/sync_buffer.go | Adds a buffered block handoff mechanism between deliverer and committer. |
| node/assembler/synchronizer/genesis_fetcher_factory.go | Adds genesis fetcher factory building a comm.BlockPuller configured for assembler endpoints. |
| node/assembler/synchronizer/block_verifier.go | Adds verifier factory abstraction (currently a noop verifier implementation). |
| node/assembler/synchronizer/mocks/verifier_factory.go | Generated mock for verifier factory. |
| node/assembler/synchronizer/mocks/synchronizer_with_stop.go | Generated mock for synchronizer interface. |
| node/assembler/synchronizer/mocks/synchronizer_factory.go | Generated mock for synchronizer factory. |
| node/assembler/synchronizer/mocks/genesis_fetcher.go | Generated mock for genesis fetcher. |
| node/assembler/synchronizer/mocks/genesis_fetcher_factory.go | Generated mock for genesis fetcher factory. |
| node/assembler/synchronizer/mocks/bft_deliverer_factory.go | Generated mock for BFT deliverer factory. |
| node/assembler/synchronizer/mocks/bft_block_deliverer.go | Generated mock for BFT block deliverer. |
| node/assembler/synchronizer/mocks/assembler_support.go | Generated mock for AssemblerSupport. |
Files not reviewed (8)
- node/assembler/synchronizer/mocks/assembler_support.go: Generated file
- node/assembler/synchronizer/mocks/bft_block_deliverer.go: Generated file
- node/assembler/synchronizer/mocks/bft_deliverer_factory.go: Generated file
- node/assembler/synchronizer/mocks/genesis_fetcher.go: Generated file
- node/assembler/synchronizer/mocks/genesis_fetcher_factory.go: Generated file
- node/assembler/synchronizer/mocks/synchronizer_factory.go: Generated file
- node/assembler/synchronizer/mocks/synchronizer_with_stop.go: Generated file
- node/assembler/synchronizer/mocks/verifier_factory.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
tock-ibm
reviewed
Jul 6, 2026
Contributor
There was a problem hiding this comment.
This can be common to both consenter and assembler, no?
Contributor
Author
There was a problem hiding this comment.
yes, I plan to place all shared code in a common place
Signed-off-by: Dor.Katzelnick <Dor.Katzelnick@ibm.com>
Signed-off-by: Dor.Katzelnick <Dor.Katzelnick@ibm.com>
DorKatzelnick
force-pushed
the
assemblerSyncPart1
branch
from
7815d91 to
b64e1ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.