config preparations for assembler synchronizer#960
Open
DorKatzelnick wants to merge 2 commits into
Open
Conversation
tock-ibm
previously approved these changes
Jul 2, 2026
tock-ibm
force-pushed
the
configSynch
branch
3 times, most recently
from
8ca73a8 to
f2cc0ec
Compare
DorKatzelnick
force-pushed
the
configSynch
branch
from
f2cc0ec to
59d10e3
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prepares configuration extraction utilities for an upcoming “assembler synchronizer” by introducing an assembler-specific shared-config data structure and helper functions to derive assembler endpoints from consensus metadata.
Changes:
- Added
AssemblerInfoto the node config model. - Added
ExtractAssemblers()to derive per-party assembler connection info from shared config. - Added
ExtractAssemblerAddresses()to build aParty2Endpointmap of assembler endpoints from orderer consensus metadata.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| node/config/config.go | Introduces AssemblerInfo to represent shared assembler endpoint and TLS material. |
| config/config.go | Adds extraction helpers to produce assembler connection data and address maps from shared/consensus config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DorKatzelnick
force-pushed
the
configSynch
branch
from
b8cf987 to
88e911b
Compare
Signed-off-by: Dor.Katzelnick <Dor.Katzelnick@ibm.com>
Signed-off-by: Dor.Katzelnick <Dor.Katzelnick@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#783