Add chaos test GitHub Actions workflow#917
Open
moran-abilea wants to merge 1 commit into
Open
Conversation
4ec6e20 to
97c8f81
Compare
7bf7dd2 to
2ac8514
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a scheduled/manual GitHub Actions workflow to run automated chaos testing for ARMA on a single GitHub-hosted runner, plus a related refactor that removes “primary signature” fields/methods from batch/BAF types and updates call sites/tests accordingly.
Changes:
- Add a new
Chaos TestGitHub Actions workflow with scheduled andworkflow_dispatchruns, artifact upload, and configurable parameters. - Add bash runner scripts to generate configs, start the ARMA network, inject chaos (stop/start components), monitor completion, and collect results.
- Remove
PrimarySignaturefrom coreBatch/BatchAttestationFragmentinterfaces and update constructors/call sites, mocks, and tests to match the new signatures.
Reviewed changes
Copilot reviewed 38 out of 46 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/chaos-test.yml |
Adds the scheduled/manual chaos-test workflow and artifact upload steps. |
.github/workflows/chaosRunner/chaos-test.sh |
Orchestrates config generation, network startup, load/receive, chaos runner, monitoring, and result collection. |
.github/workflows/chaosRunner/start-arma-network.sh |
Starts consensus/batcher/assembler/router processes and records PIDs. |
.github/workflows/chaosRunner/chaos-runner.sh |
Implements sequential stop/restart chaos pattern per party/shard. |
.github/workflows/chaosRunner/monitor-completion.sh |
Monitors duration/early completion, prints periodic stats, and signals stop. |
.github/workflows/chaosRunner/collect-results.sh |
Collects logs/statistics and writes a human-readable summary report. |
common/types/types.go |
Removes PrimarySignature() from Batch and BatchAttestationFragment interfaces. |
common/types/simple_batch.go |
Removes stored primary signature from SimpleBatch and updates constructor. |
common/types/simple_batch_test.go |
Updates tests for the new NewSimpleBatch signature. |
common/types/simple_baf.go |
Removes primary signature from SimpleBatchAttestationFragment and ASN.1 encoding; updates constructor/docs. |
common/types/simpla_baf_test.go |
Updates tests for the new NewSimpleBatchAttestationFragment signature. |
common/types/tools_test.go |
Updates helper tests to use the new BAF constructor signature. |
node/ledger/batch_encoding.go |
Removes PrimarySignature() from FabricBatch implementation. |
node/consensus/utils.go |
Updates config block metadata construction to match new batch constructor signature. |
node/consensus/state/state_test.go |
Updates consensus state serialization tests for new BAF constructor signature. |
node/consensus/setup_test.go |
Updates CreateBAF test helper calls for new CreateBAF signature. |
node/consensus/consenter_test.go |
Updates tests to the new BAF constructor signature. |
node/consensus/consensus_test.go |
Updates many test BAF creations to the new CreateBAF signature. |
node/consensus/consensus_real_reconfig_test.go |
Updates CreateBAF usage to new signature in reconfig test. |
node/batcher/batcher.go |
Updates Batcher.CreateBAF and CreateBAF to drop the primary signature parameter. |
node/batcher/batcher_role.go |
Updates BAF creation to drop primary signature usage and removes signature-related TODO. |
node/batcher/batcher_test.go |
Updates tests to new BAF constructor signature. |
node/batcher/batcher_role_test.go |
Updates tests to new NewSimpleBatch / NewSimpleBatchAttestationFragment and mock BAFCreator signature. |
node/batcher/batcher_role_old_test.go |
Updates legacy tests/bench helpers to new batch/BAF constructor + BAFCreator signature. |
node/batcher/mocks/baf_creator.go |
Updates mock BAFCreator interface/signature to drop primary signature arg. |
node/batcher/mocks/state_provider.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/request_verifier.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/request_inspector.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/mem_pool.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/decision_replicator.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/consenter_control_event_sender.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/consenter_control_event_sender_creator.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/consensus_decision_replicator_creator.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/config_sequence_getter.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/complainer.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/batches_puller.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/batched_requests_verifier.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/batch_ledger.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/batch_acker.go |
Minor mock stub invocation refactor (no functional change intended). |
node/batcher/mocks/baf_sender.go |
Minor mock stub invocation refactor (no functional change intended). |
node/assembler/utils_test.go |
Updates assembler tests to new NewSimpleBatch signature. |
node/assembler/prefetch_benchmark/batch_generator_test.go |
Updates benchmark helper to new NewSimpleBatch signature. |
node/assembler/collator_test.go |
Updates test batches to new NewSimpleBatch signature. |
node/assembler/assembler_deliver_test.go |
Updates deliver tests to new NewSimpleBatch signature. |
node/assembler/assembler_batcher_consenter_test.go |
Updates integration-style assembler tests to new NewSimpleBatch signature. |
test/reconfig/configtx/config_disseminate_test.go |
Updates BAF creation in reconfig test to new constructor signature. |
Files not reviewed (8)
- node/batcher/mocks/baf_creator.go: Generated file
- node/batcher/mocks/baf_sender.go: Generated file
- node/batcher/mocks/batch_acker.go: Generated file
- node/batcher/mocks/batch_ledger.go: Generated file
- node/batcher/mocks/batched_requests_verifier.go: Generated file
- node/batcher/mocks/batches_puller.go: Generated file
- node/batcher/mocks/complainer.go: Generated file
- node/batcher/mocks/config_sequence_getter.go: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f9b5ba7 to
34a65f6
Compare
34a65f6 to
41898a3
Compare
41898a3 to
64e0c64
Compare
tock-ibm
reviewed
Jun 25, 2026
1db5473 to
81f1fac
Compare
f343bb3 to
f3b3d25
Compare
f3b3d25 to
391761b
Compare
391761b to
d9c52cd
Compare
also fixing review notes adding readme.md as well Signed-off-by: Moran Abilea <moran.abilea@ibm.com>
d9c52cd to
e3fbfd5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds automated chaos testing infrastructure for ARMA:
The workflow runs all ARMA components as separate processes on a single GitHub-hosted runner, with chaos testing that sequentially stops and restarts components to test system resilience.
Files added: