[dependency] idemix update#127
Conversation
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
requested review from
cendhu and
liran-funaro
and removed request for
liran-funaro
|
coverage: 82.586% (-0.09%) from 82.679% — adecaro:idemix-update into hyperledger:main |
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
| } | ||
|
|
||
| func getMspConfig(dir string, ID string, sigid *msp.SigningIdentityInfo) (*msp.MSPConfig, error) { | ||
| //nolint:gocognit |
There was a problem hiding this comment.
nit: please specify the issue and why it can be ignored
| //nolint:gocognit | |
| //nolint:gocognit // <issue> can be ignored because <reason> |
| } | ||
| idemixMSP, ok := msp.(*idemixmsp.Idemixmsp) | ||
| if !ok { | ||
| panic("Invalid idemix msp") |
There was a problem hiding this comment.
major: We can return an error here instead of panicking.
| } | ||
| idemixMSP, ok := msp.(*idemixmsp.Idemixmsp) | ||
| if !ok { | ||
| panic("Invalid idemix msp") |
There was a problem hiding this comment.
major: We can return an error here instead of panicking.
| } | ||
| idemixID, ok := id.(*idemixmsp.Idemixidentity) | ||
| if !ok { | ||
| panic("identity is not idemix") |
There was a problem hiding this comment.
major: We can return an error here instead of panicking.
| } | ||
| idemixID, ok := id.(*idemixmsp.Idemixidentity) | ||
| if !ok { | ||
| panic("identity is not idemix") |
There was a problem hiding this comment.
major: We can return an error here instead of panicking.
| } | ||
| idemixID, ok := id.(*idemixmsp.IdemixSigningIdentity) | ||
| if !ok { | ||
| panic("identity is not idemix") |
There was a problem hiding this comment.
major: We can return an error here instead of panicking.
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
|
@liran-funaro , these issues are not caused by my PR. I think the linter was not run before on that code and it never signaled the issue. |
add explanation for nolint directive Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
|
Hi @liran-funaro , I believe I have addressed all your comments. Please, have another check 🙏 |
3 participants
Type of change
Description
This PR brings in the latest version of idemix.
No breaking changes are expected.
Additional details (Optional)
Related issues