[BREAKING] [dependency] Replace unmaintained library govaluate with expr#126
Merged
Conversation
liran-funaro
force-pushed
the
replace-govaluate
branch
3 times, most recently
from
608ed5c to
ec91d70
Compare
|
coverage: 82.468% (-0.07%) from 82.542% — liran-funaro:replace-govaluate into hyperledger:main |
liran-funaro
force-pushed
the
replace-govaluate
branch
4 times, most recently
from
056a0d8 to
5055a89
Compare
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
liran-funaro
force-pushed
the
replace-govaluate
branch
from
5055a89 to
59ca22c
Compare
cendhu
reviewed
Jul 2, 2026
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
Contributor
|
I'm good with this but I think it introduces a breaking change because we cannot guarantee the two libraries agree on all inputs. |
liran-funaro
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
github.com/Knetic/govaluatewith a maintained versiongithub.com/expr-lang/exprRelated issues
github.com/Knetic/govaluate#125