Skip to content

[dependencies] Remove unmaintained dependency "zap-logfmt"#54

Open
liran-funaro wants to merge 1 commit into
hyperledger:mainfrom
liran-funaro:remove-zap-logfmt
Open

[dependencies] Remove unmaintained dependency "zap-logfmt"#54
liran-funaro wants to merge 1 commit into
hyperledger:mainfrom
liran-funaro:remove-zap-logfmt

Conversation

@liran-funaro

Copy link
Copy Markdown
Contributor

The package github.com/sykesm/zap-logfmt is no longer maintained (last commit was 5 years ago).
This commit removes this dependency.

@liran-funaro liran-funaro requested a review from a team as a code owner June 28, 2026 11:01
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
@liran-funaro

liran-funaro commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Pass all Fabric unit tests: https://github.com/liran-funaro/fabric/actions/runs/28320919435

@liran-funaro

Copy link
Copy Markdown
Contributor Author

@pfi79 , friendly ping on this whenever you get a chance to review. Thanks!

@pfi79

pfi79 commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

I'll try to criticize your PR.:

  1. here is the commit that added logfmt. It seems to me that you have deleted more code than necessary in your change.
  2. I still don't like that with the removal of the library dependency, you also removed the logfmt setting. Try to keep logfmt, but remove the dependency on the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency on github.com/sykesm/zap-logfmt

3 participants