[dependencies] Remove unmaintained dependency "zap-logfmt"#54
Open
liran-funaro wants to merge 1 commit into
Open
[dependencies] Remove unmaintained dependency "zap-logfmt"#54liran-funaro wants to merge 1 commit into
liran-funaro wants to merge 1 commit into
Conversation
Signed-off-by: Liran Funaro <liran.funaro@gmail.com>
1eb6551 to
07cb530
Compare
Contributor
Author
|
Pass all Fabric unit tests: https://github.com/liran-funaro/fabric/actions/runs/28320919435 |
iliecirciumaru
approved these changes
Jul 1, 2026
Contributor
Author
|
@pfi79 , friendly ping on this whenever you get a chance to review. Thanks! |
Contributor
|
I'll try to criticize your PR.:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The package
github.com/sykesm/zap-logfmtis no longer maintained (last commit was 5 years ago).This commit removes this dependency.
github.com/sykesm/zap-logfmt#53