fix(datagram): preserve quarter stream id#340
Open
HeikoBornholdt wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
h3-datagramencoded the Quarter Stream ID correctly, but then stored a zeroed buffer inEncodedDatagram. As a result, every outgoing HTTP/3 Datagram was serialized with Quarter Stream ID0.This breaks datagrams for later request streams on the same HTTP/3 connection, for example when multiple MASQUE CONNECT-UDP sessions share one H3 connection. Those datagrams appear to belong to the first request stream and may be routed to the wrong session, ignored, or rejected.