Skip to content

chore: Remove the 'saved searches and dashboards have moved' callout#2299

Open
pulpdrew wants to merge 1 commit into
mainfrom
drew/remove-search-dashboard-callout
Open

chore: Remove the 'saved searches and dashboards have moved' callout#2299
pulpdrew wants to merge 1 commit into
mainfrom
drew/remove-search-dashboard-callout

Conversation

@pulpdrew
Copy link
Copy Markdown
Contributor

@pulpdrew pulpdrew commented May 18, 2026

Summary

This PR removes the 'saved searches and dashboards have moved' message, since its been around for long enough that users have probably found their dashboards and searches.

Screenshots or video

before

Screenshot 2026-05-18 at 3 32 21 PM

after

Screenshot 2026-05-18 at 3 32 32 PM

Closes HDX-3827

@vercel
Copy link
Copy Markdown

vercel Bot commented May 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-oss Ready Ready Preview, Comment May 18, 2026 7:34pm

Request Review

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label May 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 1
  • Production lines changed: 14
  • Branch: drew/remove-search-dashboard-callout
  • Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions
Copy link
Copy Markdown
Contributor

PR Review

✅ No critical issues found.

Clean removal of a stale onboarding callout. Anchor and Link imports remain in use elsewhere in AppNav.tsx, and the changeset is included.

@github-actions
Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

The diff removes a stale informational callout (14 JSX lines) from AppNav.tsx and adds a corresponding changeset. The removed block is purely presentational — no event handlers, state, effects, or conditional logic depend on it. Anchor and Link imports remain in use elsewhere in the same file (lines 409, 449), so no dead imports are introduced. No tests, stories, or other code reference the removed copy. Nothing further to flag.


Reviewers (4): correctness, testing, maintainability, project-standards

@github-actions
Copy link
Copy Markdown
Contributor

E2E Test Results

All tests passed • 177 passed • 3 skipped • 1153s

Status Count
✅ Passed 177
❌ Failed 0
⚠️ Flaky 4
⏭️ Skipped 3

Tests ran across 4 shards in parallel.

View full report →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant