fix(ci): clear the E2E and Python drift the earlier failures were hiding#126
Conversation
The displays-page E2E test drove the simulator create/edit/delete UI that d753a92 removed by explicit call when Studio became the only nav. E2E only executes on main pushes, and main had been red since before that commit landed, so the suite never got to fail against the new IA until the earlier lanes were fixed. The daemon simulator API keeps its coverage in display_api_tests and the API E2E spec; the UI surface this test exercised no longer exists, so the test goes with it, exactly as wave 8 did for the inline unit tests. The global-setup simulator seed stays — it exercises the create API on every run and gives display-dependent tests a device. Not verified locally: the E2E harness builds the full Linux stack. CI is the verifier. Co-Authored-By: Nova (Claude Opus 5) <noreply@anthropic.com>
Second half of the generated-artifact drift from the spec-71 input work: the WS protocol gained the input-event surface while CI was red, so the checked-in constants never got a green regeneration. just python-ws-protocol-check passes after this. Co-Authored-By: Nova (Claude Opus 5) <noreply@anthropic.com>
|
Warning Review limit reached
Next review available in: 52 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Third and hopefully final layer of the masked-failure onion. With the evdev
lint and the servo-lane import fixed, the conditional jobs finally executed on
main and surfaced two more stale artifacts:
d753a92 removed by explicit call when Studio became the only nav. E2E only
runs on main pushes and main was already red when that landed, so the suite
never got to fail against the new IA until now. The daemon simulator API
keeps its coverage (display_api_tests + api spec); the orphaned UI journey is
retired, matching what wave 8 did to the inline tests. Global-setup still
seeds a simulator.
after spec-71 added the input-event surface. Regenerated;
just python-ws-protocol-checkpasses.E2E is not verifiable locally (Linux stack build) — CI is the verifier here.
🤖 Generated with Claude Code