Skip to content

fix(ci): clear the E2E and Python drift the earlier failures were hiding#126

Merged
hyperb1iss merged 2 commits into
mainfrom
fix/ci-e2e-ws-drift
Jul 26, 2026
Merged

fix(ci): clear the E2E and Python drift the earlier failures were hiding#126
hyperb1iss merged 2 commits into
mainfrom
fix/ci-e2e-ws-drift

Conversation

@hyperb1iss

Copy link
Copy Markdown
Owner

Third and hopefully final layer of the masked-failure onion. With the evdev
lint and the servo-lane import fixed, the conditional jobs finally executed on
main and surfaced two more stale artifacts:

  • E2E (both legs): the displays-page journey drove the simulator UI that
    d753a92 removed by explicit call when Studio became the only nav. E2E only
    runs on main pushes and main was already red when that landed, so the suite
    never got to fail against the new IA until now. The daemon simulator API
    keeps its coverage (display_api_tests + api spec); the orphaned UI journey is
    retired, matching what wave 8 did to the inline tests. Global-setup still
    seeds a simulator.
  • Python Client: the WS protocol constants never got a green regeneration
    after spec-71 added the input-event surface. Regenerated;
    just python-ws-protocol-check passes.

E2E is not verifiable locally (Linux stack build) — CI is the verifier here.

🤖 Generated with Claude Code

hyperb1iss and others added 2 commits July 25, 2026 23:14
The displays-page E2E test drove the simulator create/edit/delete UI
that d753a92 removed by explicit call when Studio became the only nav.
E2E only executes on main pushes, and main had been red since before
that commit landed, so the suite never got to fail against the new IA
until the earlier lanes were fixed.

The daemon simulator API keeps its coverage in display_api_tests and
the API E2E spec; the UI surface this test exercised no longer exists,
so the test goes with it, exactly as wave 8 did for the inline unit
tests. The global-setup simulator seed stays — it exercises the create
API on every run and gives display-dependent tests a device.

Not verified locally: the E2E harness builds the full Linux stack. CI
is the verifier.

Co-Authored-By: Nova (Claude Opus 5) <noreply@anthropic.com>
Second half of the generated-artifact drift from the spec-71 input
work: the WS protocol gained the input-event surface while CI was red,
so the checked-in constants never got a green regeneration. just
python-ws-protocol-check passes after this.

Co-Authored-By: Nova (Claude Opus 5) <noreply@anthropic.com>
@hyperb1iss
hyperb1iss merged commit 59e00c1 into main Jul 26, 2026
@hyperb1iss
hyperb1iss deleted the fix/ci-e2e-ws-drift branch July 26, 2026 06:14
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@hyperb1iss, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b1b591bc-7974-43d2-93f1-4e191fcb7161

📥 Commits

Reviewing files that changed from the base of the PR and between ba60bb8 and da3f064.

📒 Files selected for processing (2)
  • e2e/tests/ui.spec.mjs
  • python/src/hypercolor/ws_protocol.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant