Skip to content

fix(ci): clear the two failures the evdev lint was masking#125

Merged
hyperb1iss merged 2 commits into
mainfrom
fix/main-ci-followups
Jul 26, 2026
Merged

fix(ci): clear the two failures the evdev lint was masking#125
hyperb1iss merged 2 commits into
mainfrom
fix/main-ci-followups

Conversation

@hyperb1iss

@hyperb1iss hyperb1iss commented Jul 26, 2026

Copy link
Copy Markdown
Owner

Main went red again after #124 merged — not from the new work, but from two
pre-existing failures the week-old evdev lint had been masking in the same jobs:

  • Servo lane: EffectCategory is only consumed behind
    cfg(feature = "servo-gpu-import"), so building with servo alone leaves
    the import dead and -D warnings fails. Qualified at the use site. Verified
    locally with clippy -p hypercolor-core --features servo -- -D warnings
    the first time that feature surface has been linted outside CI.
  • Python client drift: the stale models are the spec-71 input-status
    surface, which landed while CI was already red and never got a green
    regeneration. just python-generate-check passes after regenerating.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor
    • Updated internal effect-category references for improved clarity and compatibility.
    • No user-facing behavior changes.

hyperb1iss and others added 2 commits July 25, 2026 22:04
The only consumer of EffectCategory in the servo renderer sits behind
cfg(feature = "servo-gpu-import"), so building with servo alone leaves
the import dead and -D warnings fails the lane. Qualify it at the use
site instead.

This was invisible until now for two stacked reasons: the evdev lint
that kept main red since 2026-07-21 failed the same jobs first, and
clippy only lints the package it is pointed at, so daemon runs compile
core without lints and no local run ever linted core with the servo
feature enabled.

Co-Authored-By: Nova (Claude Opus 5) <noreply@anthropic.com>
The drift gate failed on main after the merge; the stale models are the
spec-71 input-status surface, which landed while CI was already red and
never got a green regeneration. just python-generate-check passes after
this.

Co-Authored-By: Nova (Claude Opus 5) <noreply@anthropic.com>
@hyperb1iss
hyperb1iss merged commit ba60bb8 into main Jul 26, 2026
3 of 4 checks passed
@hyperb1iss
hyperb1iss deleted the fix/main-ci-followups branch July 26, 2026 05:07
@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b915caf6-b2a7-489b-8e85-f06702c6c0f7

📥 Commits

Reviewing files that changed from the base of the PR and between 85b0620 and d131326.

⛔ Files ignored due to path filters (4)
  • python/src/hypercolor/_generated/models/__init__.py is excluded by !**/_generated/**
  • python/src/hypercolor/_generated/models/api_response_system_status_data.py is excluded by !**/_generated/**
  • python/src/hypercolor/_generated/models/input_status.py is excluded by !**/_generated/**
  • python/src/hypercolor/_generated/models/system_status.py is excluded by !**/_generated/**
📒 Files selected for processing (1)
  • crates/hypercolor-core/src/effect/servo/renderer.rs

📝 Walkthrough

Walkthrough

The servo renderer stops importing EffectCategory directly and uses a fully qualified hypercolor_types::effect::EffectCategory::Display reference in the GPU frame reuse check.

Changes

Renderer reference update

Layer / File(s) Summary
Qualified EffectCategory usage
crates/hypercolor-core/src/effect/servo/renderer.rs
Removes the direct EffectCategory import and qualifies the Display comparison, with explanatory comments.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Poem

I’m a bunny with code so neat,
A qualified type makes imports fleet.
The renderer hops without a fuss,
Display now knows exactly us.
Clean little changes—carrot treat!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant