fix(ci): clear the two failures the evdev lint was masking#125
Conversation
The only consumer of EffectCategory in the servo renderer sits behind cfg(feature = "servo-gpu-import"), so building with servo alone leaves the import dead and -D warnings fails the lane. Qualify it at the use site instead. This was invisible until now for two stacked reasons: the evdev lint that kept main red since 2026-07-21 failed the same jobs first, and clippy only lints the package it is pointed at, so daemon runs compile core without lints and no local run ever linted core with the servo feature enabled. Co-Authored-By: Nova (Claude Opus 5) <noreply@anthropic.com>
The drift gate failed on main after the merge; the stale models are the spec-71 input-status surface, which landed while CI was already red and never got a green regeneration. just python-generate-check passes after this. Co-Authored-By: Nova (Claude Opus 5) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe servo renderer stops importing ChangesRenderer reference update
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Main went red again after #124 merged — not from the new work, but from two
pre-existing failures the week-old evdev lint had been masking in the same jobs:
EffectCategoryis only consumed behindcfg(feature = "servo-gpu-import"), so building withservoalone leavesthe import dead and
-D warningsfails. Qualified at the use site. Verifiedlocally with
clippy -p hypercolor-core --features servo -- -D warnings—the first time that feature surface has been linted outside CI.
surface, which landed while CI was already red and never got a green
regeneration.
just python-generate-checkpasses after regenerating.🤖 Generated with Claude Code
Summary by CodeRabbit