Fix indent on immediately applied function definition/evaluation results. - #102
Open
jams2 wants to merge 2 commits into
Open
Fix indent on immediately applied function definition/evaluation results.#102jams2 wants to merge 2 commits into
jams2 wants to merge 2 commits into
Conversation
Add helper functions for indent function
Author
|
Apologies - after reviewing the tests I can see that this is intended behavior of hy-mode: (it "form opens a form - only sexp on line"
(expect "
((a b)
c)
" :indented))I know indentation can be a contentious topic, so let me know if this is something worth further discussion, otherwise I'll just use my own fork :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hope you don't mind the unsolicited PR but I made the changes for my own use anyway so thought it makes sense to share.
Current behaviour (installed from master):
The indentation of the rest of the forms in the outermost expression (1, 7, 3, 4) is currently "one past the opening paren of the previous sexp". This differs from Hy's style guide (see the third law) and indentation in other lisp modes (e.g. elisp mode), and to my eye is confusing. This PR changes the behaviour so the previous example will be indented as such:
I also added
assoctohy-indent--exactly, to bring behaviour in line with the style guide (see special arguments).