fix: preserve graphassets images during HTML import#136
Conversation
🦋 Changeset detectedLatest commit: 7aad5d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
flexzuu
left a comment
There was a problem hiding this comment.
Looking good, I repeat fabis concern and my comment ehere here but i think this should not block the merge. We can deal with this if it ever becomes an issue.
@Jonas Do you think this might cause any issues if I import images from other environments or projects? If it's in the public package that could happen for customers theoretically (edited)
yeah it could lead to not found issues on the project for sure, so ideally we would check if the asset-env-id also matches and maybe even check the asset still exists in the project but on the other hand you may have similar issues with assets that you link without using proper embeds and then go and delete the asset.
This change ensures that graphassets images are preserved when importing HTML.
Summary