v0.20.2: pin SCREENING_SHARD_GROUPS in shard tests#79
Merged
Conversation
The 2026-07-23 scheduled run failed before the agent started: the workflow's pre-run test suite executes under the CI env where SCREENING_SHARD_GROUPS=2 (v0.20.1), and two older shard tests assumed the 4-group split without pinning the variable — green locally (default 4), red in CI, no daily produced. Both tests now pin the group count explicitly; the discussion-first ordering test asserts it in both group modes. Test-only change. Suite verified under both envs (259 pass each). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JXjb8D4NrsgUXAvQodQSum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes today's scheduled-run failure (second comment on Issue #76): the run died before the agent started. The workflow's pre-run test suite executes under the CI env, where v0.20.1 set
SCREENING_SHARD_GROUPS=2— and two older shard tests (test_screening_shard_split_by_lane,test_discussion_shard_runs_first) assumed the 4-group split without pinning the variable. Green locally (default 4), red in CI (2), exit 1, no daily produced. My miss in #78: I pinned the env in the new tests but didn't audit the old ones for ambient-env sensitivity.SCREENING_SHARD_GROUPSexplicitly; the discussion-first ordering test asserts it in both group modes (the merged group leads withdiscussion-official, preserving community framing in dedup).Validation
SCREENING_SHARD_GROUPS=2(CI config) — 259 tests pass in each.🤖 Generated with Claude Code
https://claude.ai/code/session_01JXjb8D4NrsgUXAvQodQSum
Generated by Claude Code