Embed dashboard UI.#29
Open
simonbuchan wants to merge 2 commits into
Open
Conversation
Uses the `static_serve` approach since I'm lazy... Fixes huseyinbabal#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #28
Description
Uses the
serve_staticapproach I described in the issue, since I'm lazy:build.rsto build the UI automatically, which should makecargo installwork (I guess we'll find out?)tower_httpmiddleware with theserve_staticrouter./dashboard/whateverdoesn't try to loads3:://dashboard/whateverwhich I feel would be confusing.Type of Change
Checklist
Additional Notes
This (unsurprisingly) means building the binary now requires the ability to do the UI build, e.g. have a node install. This is true for Github Actions runners, so that should be fine, but I suppose it would be reasonable to be able to disable the dashboard by making it a default feature to unblock people that don't need it?
If that's desired I could take a look at doing so in a separate PR.