fix(#231): consolidate CORS to a single same-origin-default policy#236
Open
husamql3 wants to merge 1 commit into
Open
fix(#231): consolidate CORS to a single same-origin-default policy#236husamql3 wants to merge 1 commit into
husamql3 wants to merge 1 commit into
Conversation
- Remove the manual "*"-echoing CORS middleware; keep one mechanism - Configure hono/cors with an empty-by-default origin allowlist (ALLOWED_ORIGINS env, comma-separated) so cross-origin requests get no Access-Control-Allow-Origin header -> same-origin only - Prevents drive-by-localhost: any other browser tab can no longer issue cross-origin reads/edits/drops against the user's DB - Update server CORS tests to assert the new policy (no allow-origin for a cross-origin/no-origin request; methods/headers advertised on preflight)
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Bundle Size
File breakdown
File breakdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cors()and then a second middleware that hard-setAccess-Control-Allow-Origin: *on every response. Two mechanisms is a correctness hazard and the wildcard grants cross-origin access the app never needs (the SPA is served same-origin as the API).ALLOWED_ORIGINS— with no allowlist configured, no allow-origin header is emitted for cross-origin requests. Deployments serving the SPA from a different origin setALLOWED_ORIGINSto an explicit comma-separated list (never*).Testing
cd packages/server && bun run test→ 998 tests passbun run typecheck,bun run format,bun run build→ passCloses #231
Glossary
ALLOWED_ORIGINS