Fix: back button exits reader in one click and restore search state on back navigation#99
Merged
Merged
Conversation
…n back navigation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The reader's back button previously used navigate(-1), which required multiple clicks after ToC/bookmark/search jumps that pushed history entries. It now navigates directly to location.state.from (set by all call sites), falling back to navigate(-1) for direct URL access.
Global search and in-system search now restore their query and results on back navigation: SearchView syncs the query to ?q= so returning to the URL replays the search, and SystemDetailView persists the query in sessionStorage.
Closes #98
Type of change
Testing
pytest -q)npm test)Notes for reviewer